ros: remove linter warnings from spread tests
Metadata
Current evaluation
Cherry-picked and merged PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. Approved by one reviewer, passed CI, and deleted seven lines across one file.
Suggested action: —
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Cherry-pick https://github.com/snapcore/snapcraft/pull/4202 onto `hotfix/7.4`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Cherry-picked and merged PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. Approved by one reviewer, passed CI, and deleted seven lines across one file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cherry-pick of PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cherry-pick of PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4202 ros: remove generator warnings from linter spread tests | snapcraft | merged | Merged removal of generator warnings from ROS linter spread tests. Contributors traced warnings to upstream ROS library updates, not linter changes. The update deletes seven lines, passed CI, and merged with no coverage impact. | |
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged into main after two approvals and passing CI. The change relaxes the ROS linter spread test to properly filter libpng warnings while retaining ros2-humble checks, resolving issue #4256. | |
| #4212 Revert "ros: remove linter warnings from spread tests (#4202)" | snapcraft | merged | Merged to restore linter warnings to spread tests by reverting commit d48db22. Approved by one reviewer, passed CI, and modified one file (+7/-0) without impacting code coverage. | |
| #4223 ros: make linter tests more flexible | snapcraft | merged | Merged changes to make ROS linter tests more flexible, resolving flaky failures in the linter-ros2-humble-mixed spread test caused by fluctuating unused library lists. Approved and passed CI. | |
| #4113 tests: update linter-ros2-humble-mixed spread test | snapcraft | merged | Merged into main after approval and passing CI. Updates a broken ros2 humble spread test caused by removed extension libraries, removing 7 lines of outdated code to restore test stability. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged removal of core24 ros2 extension linter tests, as no ROS 24.04 or extension exists. Approved by two reviewers, passed CI, and maintained coverage. Deleted 101 lines across five files. | |
| #4954 tests: update spread tests in hotfix/7.5 | snapcraft | merged | Merged into hotfix/7.5 to update spread tests and repair CI. The branch includes six cherry-picks and six new commits, passed all CI and coverage checks, received reviewer approval, and unblocked issues #4950 and #4936. |