ros: remove linter warnings from spread tests
Metadata
Current evaluation
Merged #4203 into hotfix/7.4, cherry-picking #4202 to remove seven lines of ROS spread-test linter-warning expectations.
Resolution: closed resolved
Reason: PR #4203 was approved and merged, backporting #4202's seven-line deletion to hotfix/7.4. The equivalent master change was later reverted by #4212 (13071d7a0).
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Cherry-pick https://github.com/snapcore/snapcraft/pull/4202 onto `hotfix/7.4`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4203 into hotfix/7.4, cherry-picking #4202 to remove seven lines of ROS spread-test linter-warning expectations. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4203 cherry-picked #4202 onto hotfix/7.4, removing seven lines of ROS spread-test linter warnings. The equivalent master change was later reverted by #4212. | |
| qwen/qwen3.6-35b-a3b | — | — | Cherry-picked and merged PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. Approved by one reviewer, passed CI, and deleted seven lines across one file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cherry-pick of PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. |
Update history
No update history recorded yet.
Related work
-
Caused By:
snapcraft#4202
(confidence 100%)
Original master-branch change cherry-picked by this hotfix PR.
-
Related To:
snapcraft#4212
(confidence 98%)
Reverted the equivalent #4202 change on master in commit 13071d7a0.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4212 Revert "ros: remove linter warnings from spread tests (#4202)" | snapcraft | merged | Merged #4212 (13071d7a0), reverting d48db220 from #4202 and restoring seven ROS linter-warning expectations in spread tests. | |
| #4202 ros: remove generator warnings from linter spread tests | snapcraft | merged | Merged PR #4202 removed seven generator-warning expectation lines from ROS linter spread tests, aligning fixtures with changed upstream ROS dependency output; Snapcraft's linter was unchanged. | |
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged in #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; fixes #4256. | |
| #4113 tests: update linter-ros2-humble-mixed spread test | snapcraft | merged | Merged #4113 as commit 2735e2c3c, removing seven outdated ROS 2 Humble mixed spread-test expectations after extension libraries were removed. | |
| #4223 ros: make linter tests more flexible | snapcraft | merged | Merged #4223 as commit 64c8f1e87, making the ROS2 Humble mixed linter spread test tolerate changing unused-library lists and prevent flaky failures. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged PR #4595 (commit 043584583) removing Core 24 ROS 2 extension linter spread tests from five files, since ROS for 24.04 and its extension do not exist. Approved by 2 reviewers. |