test(spread): check for new lifecycle message
Metadata
Current evaluation
Merged a test update to verify a new lifecycle message, resolving a regression from #4431. Approved by two reviewers with passing CI and stable coverage. The fix unblocks PR #4450.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Fix a test failure introduced by #4431.
Unblocks #4450
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a test update to verify a new lifecycle message, resolving a regression from #4431. Approved by two reviewers with passing CI and stable coverage. The fix unblocks PR #4450. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged test updates to verify a new lifecycle message, resolving a regression from #4431 and unblocking #4450. Code coverage remains stable. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve a test failure introduced in #4431 and unblock #4450. The change adds a test for a new lifecycle message, passes all linting and unit tests, and achieves full coverage on modified lines. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3719 tests: fix lifecycle tests to run on new directory | snapcraft | merged | Merged a fix for lifecycle tests to run in a new directory instead of the current one. Approved by a reviewer, passed CI, and changed three lines. | |
| #2637 unit tests: make lifecycle tests more robust | snapcraft | merged | Merged updates to improve lifecycle unit test robustness. Replaced strict message assertions with flexible checks to prevent fake webserver output from causing false failures. Approved and passed CI. | |
| #766 fix(lifecycle): don't rebuild on test file changes | craft-application | merged | Merged fix that adds spread files to the lifecycle manager's ignore list, preventing unnecessary repulls when test files change. Approved by two reviewers, passed all CI checks, and resolves issue #756. | |
| #2163 tests: add lifecycle ordering tests | snapcraft | merged | Merged changes adding lifecycle ordering tests and refactoring them into a dedicated package. Approved by a reviewer, passed CI checks, and increased code coverage by 0.02%. | |
| #4461 fix: improve lifecycle messages | snapcraft | merged | Merged after approval and passing CI. The change improves lifecycle messages by refactoring progress emission from open_stream to explicit progress calls, maintaining code coverage. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #3024 tests: remove usage of FakeApt fixtures in lifecycle | snapcraft | merged | Merged changes replacing FakeApt fixtures in lifecycle tests with targeted mock.patch calls and related cleanup. Approved by one reviewer and passed CI checks. | |
| #62 fix: improve lifecycle messages | craft-application | merged | Merged into main after two approvals. Improved lifecycle messages and expanded human-readable text with all variances across three files. Minor coverage decrease was dismissed as a Codecov artifact. | |
| #1849 tests(2.7): remove mantic spread test | charmcraft | merged | Merged to remove the Mantic spread test after the release reached end-of-life. This change fixes CI for bugfix releases on the 2.7 branch. Approved by two reviewers and passed all checks. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback. |