Spread restore no abort
Metadata
Current evaluation
Merged after approval from two reviewers and passing CI checks. Implements Spread restore no abort functionality with 100% test coverage on modified lines, changing +531/-31 lines across 29 files.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
hooks will be reworked as part of the hooks PR
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval from two reviewers and passing CI checks. Implements Spread restore no abort functionality with 100% test coverage on modified lines, changing +531/-31 lines across 29 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged sergiusens' Spread restore no abort changes. Passed tests, achieved full coverage, and was integrated into the feature/craft-application branch. Hooks rework deferred to a separate pull request. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into the feature/craft-application branch. Implements spread restore without abort. Codecov verified full test coverage for modified lines, with hooks slated for separate rework. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #127 Fix spread tests | imagecraft | merged | Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines). | |
| #4529 Spread update | snapcraft | merged | Merged after approval by two reviewers and passing CI checks. The update modifies spread configuration across three files, adding 36 and removing 40 lines. Code coverage tests passed. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #3432 spread tests: remove legacy plugin tests | snapcraft | merged | Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. | |
| #13 test(spread): add more spread tests | snapcraft-rocks | merged | Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines). | |
| #1427 tests(spread): make dependencies restore work even if no charm is built | charmcraft | merged | Merged a one-line change ensuring spread test dependencies restore correctly when no charm is built. Approved by two reviewers and successfully integrated. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback. | |
| #2216 spread tests: keep sources local | snapcraft | merged | Merged PR #2216 to replace remote FTP sources in spread tests with in-tree tar archives, preventing test failures from server downtime. Approved by one reviewer, passed CI checks, and slightly increased code coverage. |