← Back to issue list

chore: fix gitignore entry

View original Github issue

Metadata

Project
snapcraft
Number
#5266
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged a .gitignore fix that incorrectly ignored parts/ directories project-wide. The update resolves unintended side effects and restores Ruff linting. Approved by two reviewers and passed CI.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- The .gitignore was ignoring the lifecycle `parts/` directory, but it had its own `parts/` directories (e.g. `snapcraft/parts/`) that were getting ignored as a side-effect. This also meant that Ruff wasn't checking those directories for formatting/linting errors.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a .gitignore fix that incorrectly ignored parts/ directories project-wide. The update resolves unintended side effects and restores Ruff linting. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged a .gitignore fix that corrected an overly broad pattern ignoring lifecycle/parts/ and other parts/ directories. This restores Ruff linting coverage for the affected paths.
qwen3.6-35b-a3b-mtp-q6 Merged a .gitignore fix that corrected an overly broad pattern ignoring lifecycle/parts/ and other parts/ directories. This restores proper file tracking and enables Ruff linting for previously excluded paths.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#115 chore(deps): update ruff and fix linting issue craft-application merged Merged into main after two approvals and passing CI. The update refreshed the ruff dependency and resolved a linting issue across two files. Codecov recorded a negligible 0.10% coverage decrease upon merge.
81%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
79%
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
79%
#22 chore(lint): update ruff and config starbase merged Merged ruff linter and configuration updates. Added an ignore rule for test functions with excessive arguments. Approved by one reviewer, modifying two files with a +4/-2 line change.
78%
#369 chore: fix linting imagecraft merged Merged after resolving redundant casting linting errors flagged by Ty. Approved by two reviewers. Changes involved minimal edits (+2/-2 lines) across one file. CI lint and test checks passed prior to merge.
77%
#1099 chore: fix linting craft-application merged Merged a linting fix to resolve unused directives flagged by Ty. The update modified two files, received approval from two reviewers, passed CI validation, and was successfully integrated.
77%
#103 chore: fix new lints from ruff 0.12 craft-grammar merged Merged after approval and passing CI checks. Updated pre-commit ruff to 0.12 and resolved newly introduced lint errors across four files. Changes were cherry-picked from canonical/starbase#409.
77%
#1215 chore: linting rockcraft merged Merged a linting fix replacing an unnecessary str() call with a string literal in tests/unit/test_project.py to resolve ruff error UP018. Approved by two reviewers and merged.
76%
#2442 chore: fix ruff warnings from test files charmcraft merged Merged following two reviewer approvals. Fixed Ruff deprecation warnings in five test files. CI passed for most checks despite a snap-store-tests failure. Non-blocking type checker notifications required no action.
76%
#435 chore: add IDE configs to gitignore starbase merged Merged updates to .gitignore adding Zed and KDevelop IDE configuration folders and reorganizing existing IDE entries. Approved by two reviewers and passed all CI checks.
76%