sources: refactor local source into module.
Metadata
Current evaluation
Merged PR snapcore/snapcraft#961 by kyrofa extracted the Local source into sources/_local.py, merged as commit ec4b8f341. Part of the wider sources refactor series (#957, #962-#970) for LP #1648906.
Resolution: closed resolved
Reason: The PR was approved and merged into master as commit ec4b8f341 ("sources: refactor local source into module. (#961)"), which created snapcraft/sources/_local.py and moved the Local source implementation there.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR snapcore/snapcraft#961 by kyrofa extracted the Local source into sources/_local.py, merged as commit ec4b8f341. Part of the wider sources refactor series (#957, #962-#970) for LP #1648906. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #961 (commit ec4b8f341), extracting the local source into sources/_local.py as progress on LP bug #1648906. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and CI. Refactored the local source into sources/_local.py, advancing Launchpad bug #1648906. Modified four files with a +236/-191 line change and slightly increased overall code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored the local source into a dedicated module at sources/_local.py, advancing work on LP: #1648906. Code coverage increased by less than 0.01% to 96.24%. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#957
(confidence 90%)
Preceding commit1d34e9e6b 'sources: refactor base sources into module' introduced the sources package this PR builds on
-
Related To:
snapcraft#955
(confidence 85%)
Commit 0ef7dc218 'sources: convert to package' created the sources package groundwork
-
Related To:
snapcraft#963
(confidence 80%)
Sibling refactor of the deb source in the same LP #1648906 series
-
Related To:
snapcraft#964
(confidence 80%)
Sibling refactor of the git source in the same series (commit f9ee3f034)
-
Related To:
snapcraft#970
(confidence 75%)
Sibling refactor of the zip source, completing the series (commit db2a6fb6a)
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #964 sources: refactor git source into module. | snapcraft | merged | Merged PR #964 (commit f9ee3f034) by maintainer kyrofa, extracting the Git source handler out of sources.py into snapcraft/sources/_git.py as part of the sources refactor series for LP #1648906. | |
| #1558446 Pulling local sources is rather broken | snapcraft (launchpad) | closed | Local source pull bug fixed by ubuntu-core/snapcraft PR #377 (commit eb6ad38ab "Correct local source pulling", merged as 8b4a18d9b), which inverts the isdir/rmdir checks so symlinked local sources are removed rather than raising. |