← Back to issue list

sources: refactor local source into module.

View original Github issue

Metadata

Project
snapcraft
Number
#961
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and CI. Refactored the local source into sources/_local.py, advancing Launchpad bug #1648906. Modified four files with a +236/-191 line change and slightly increased overall code coverage.

Suggested action:

No scores available.

Issue body

This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Local source into `sources/_local.py`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and CI. Refactored the local source into sources/_local.py, advancing Launchpad bug #1648906. Modified four files with a +236/-191 line change and slightly increased overall code coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Refactored the local source into a dedicated module at sources/_local.py, advancing work on LP: #1648906. Code coverage increased by less than 0.01% to 96.24%.
qwen3.6-35b-a3b-mtp-q6 Merged refactoring that extracts the local source into sources/_local.py. Advances LP #1648906 and increases overall code coverage by less than 0.01%, maintaining 96.24%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#957 sources: refactor base sources into module. snapcraft merged Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906.
81%
#968 sources: refactor subversion source into module. snapcraft merged Merged refactoring that extracts the Subversion source handler into a dedicated module. Advances Launchpad bug #1648906, passed coverage checks, and received author approval. Net change: +170/-129 lines across four files.
78%
#262 Refactored the local source pull. snapcraft merged Merged a refactoring of the local source pull that added full test coverage. Approved by a reviewer who suggested future improvements to rename confusing parameters and add docstrings. The change modified two files, reducing code by 17 lines.
77%
#967 sources: refactor script source into module. snapcraft merged Merged refactoring of the Script source into a dedicated module at sources/_script.py, including basic unit tests. Approved, passed CI, and advances progress on Launchpad bug #1648906.
76%
#966 sources: refactor rpm source into module. snapcraft merged Merged a refactor extracting RPM source logic into a dedicated sources/_rpm.py module. Part of ongoing work on Launchpad bug #1648906, the change modified four files (+131/-90 lines) and slightly increased overall code coverage.
76%
#964 sources: refactor git source into module. snapcraft merged Merged a refactor extracting Git source logic into sources/_git.py. Approved by reviewer, passed CI, and slightly improved code coverage as part of ongoing bug fix LP: #1648906.
75%
#969 sources: refactor tar source into module. snapcraft merged Merged a refactor extracting the Tar source into a dedicated module at sources/_tar.py. The change adds two files, increases code coverage by less than 0.01%, and advances work on Launchpad bug #1648906.
72%
#322 sources: improve missing local source error message craft-parts merged Merged. Updates error handling to display a clear source not found message instead of a file copy error when a local source is missing. Approved by two reviewers, passed CI, and changed 17 lines across two files.
72%
#963 sources: refactor deb source into module. snapcraft merged Merged refactoring changes that extract Deb source logic into a dedicated module at sources/_deb.py. This restructuring advances progress on Launchpad bug #1648906 and passes CI checks with maintained code coverage.
71%
#363 sources: fix ignore patterns in local sources craft-parts merged Merged fix for local source ignore patterns that prevented cumulative list creation, eliminating repetitions and excessive size. Approved by reviewer, passed CI, and modified 2 files (+21/-6).
70%