← Back to issue list

test: fix ty 0.0.79 issues

View original Github issue

Metadata

Project
craft-parts
Number
#1716
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals. Fixed unit test failures related to ty 0.0.79 across five files. CI checks passed.

Suggested action:

No scores available.

Issue body

They are all in unit tests. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals. Fixed unit test failures related to ty 0.0.79 across five files. CI checks passed.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 18.0
Staleness: 0
Complexity: 10
Confidence: 85
needs review Fixes ty 0.0.79 issues in unit tests. Has 2 approvals, 0 unresolved comments, but some Java plugin CI checks are failing on specific architectures.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 18.0
Staleness: 5
Complexity: 10
Confidence: 75
needs review Small test fix PR (+11/-13 lines, 5 files) addressing ty/0.0.79 issues in unit tests. Approved by 1 reviewer with no unresolved comments. Some CI checks failing on test-java-plugins for specific architectures.
qwen/qwen3.6-35b-a3b
Impact: 15
Quick Win: 13.5
Staleness: 0
Complexity: 10
Confidence: 85
needs review Fixes ty 0.0.79 linter issues in unit tests. All CI checks passing, no reviewer activity yet.
qwen/qwen3.6-35b-a3b
Impact: 15
Quick Win: 13.5
Staleness: 5
Complexity: 10
Confidence: 85
needs review Fixes type-checking issues from ty 0.0.79 in unit tests. Fresh PR by maintainer, CI passing, 0 reviewers, small diff across 5 test files.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 18.0
Staleness: 0
Complexity: 10
Confidence: 80
needs review Fixes ty 0.0.79 linter issues in unit tests. All CI checks passing, no reviewer comments yet.

Update history

Date Change
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#6280 style: ty 0.0.44 snapcraft merged Merged update to ty version 0.0.44. Approved by two reviewers and passed core CI checks. Unrelated lint failures and integration timeouts did not block the merge.
81%
#433 fix(tests): better typing for tests starbase merged Merged improvements to test type annotations to satisfy the ty type checker. Approved by two reviewers, passed all CI checks, and applied with a minimal +7/-6 line change across one file.
76%
#1698 style: ty craft-parts merged Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review.
73%
#2726 style: switch type checking to ty charmcraft merged Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
72%
#421 style: ty craft-cli merged Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420.
72%
#5375 test: fix command tests snapcraft merged Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
71%