← Back to issue list

test: fix ty 0.0.79 issues

View original Github issue

Metadata

Project
craft-parts
Number
#1716
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1716 as commit 4ef1b34c, fixing ty 0.0.79 findings in unit tests across five files.

Resolution: closed resolved

Reason: PR #1716 was merged into the project as commit 4ef1b34c, resolving the ty 0.0.79 issues in the unit tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

They are all in unit tests. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1716 as commit 4ef1b34c, fixing ty 0.0.79 findings in unit tests across five files.
stealth/space-bunny-alpha — closed resolved Merged PR #1716 (commit 4ef1b34c), fixing ty 0.0.79 findings in unit tests across five files.
qwen/qwen3.6-35b-a3b — — Merged after two approvals. Fixed unit test failures related to ty 0.0.79 across five files. CI checks passed.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 18
Staleness: 0
Complexity: 10
Confidence: 85
needs review Fixes ty 0.0.79 issues in unit tests. Has 2 approvals, 0 unresolved comments, but some Java plugin CI checks are failing on specific architectures.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 18
Staleness: 5
Complexity: 10
Confidence: 75
needs review Small test fix PR (+11/-13 lines, 5 files) addressing ty/0.0.79 issues in unit tests. Approved by 1 reviewer with no unresolved comments. Some CI checks failing on test-java-plugins for specific architectures.
qwen/qwen3.6-35b-a3b
Impact: 15
Quick Win: 14
Staleness: 0
Complexity: 10
Confidence: 85
needs review Fixes ty 0.0.79 linter issues in unit tests. All CI checks passing, no reviewer activity yet.
qwen/qwen3.6-35b-a3b
Impact: 15
Quick Win: 14
Staleness: 5
Complexity: 10
Confidence: 85
needs review Fixes type-checking issues from ty 0.0.79 in unit tests. Fresh PR by maintainer, CI passing, 0 reviewers, small diff across 5 test files.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 18
Staleness: 0
Complexity: 10
Confidence: 80
needs review Fixes ty 0.0.79 linter issues in unit tests. All CI checks passing, no reviewer comments yet.

Update history

Date Change
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
77%
#6280 style: ty 0.0.44 snapcraft merged Merged PR #6280 in commit 8b45efc80, applying ty 0.0.44 style updates after two approvals; unrelated CI failures did not block the merge.
74%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
74%
#1126 style: fix ty errors craft-application merged Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors.
73%
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
73%
#485 style: ty 0.0.79 craft-cli closed Merged into main: a +2/-2 line one-file style fix for the new error reported by the ty 0.0.79 type checker, by maintainer mr-cal; review approved, all 25 CI checks green. Ty was later bumped to 0.0.82 in craft-parts#1727.
73%
#5970 Fix `ty` warnings snapcraft closed Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
73%
#6493 style: ty 0.0.87, ruff 0.17.0 snapcraft merged Merged PR updating ty to 0.0.87 and ruff to 0.17.0, with 7 AI-assisted commits fixing linting errors across 12 files.
72%
#910 style: fix ty error craft-providers merged Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
72%
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
72%