← Back to issue list

refactor: reorganise constants

View original Github issue

Metadata

Project
charmcraft
Number
#1357
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a refactor reorganizing constants for Charmcraft environment variables, project filenames, and output files/directories across 47 files. Changes include 471 additions and 443 deletions. Approved by four reviewers with no unresolved comments.

Suggested action:

No scores available.

Issue body

* Charmcraft environment variables * Project filenames * Output files and directories

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactor reorganizing constants for Charmcraft environment variables, project filenames, and output files/directories across 47 files. Changes include 471 additions and 443 deletions. Approved by four reviewers with no unresolved comments.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring commit that reorganizes project constants into logical groups, including Charmcraft environment variables, project filenames, and output files and directories.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring change that reorganizes constants into three groups: Charmcraft environment variables, project filenames, and output files and directories.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#993 refactor: Move charm library helper functions to their own modules (CRAFT-1557) charmcraft merged Merged refactoring extracting charm library helpers into dedicated modules, resolving CRAFT-1557. Approved by one reviewer with no unresolved comments. Modifies seven files, adding 658 lines and removing 587.
76%
#1303 refactor(utils): move charmlibs utilities charmcraft merged Merged a refactor moving charmlibs utilities across eight files, adding 61 lines and removing 42. Approved by two reviewers with zero unresolved comments.
74%
#2154 docs: replace occurrences of "charmcraft.yaml" and "recipe" charmcraft merged Merged documentation update replacing charmcraft.yaml and recipe with project or project file across 23 files. Approved by two reviewers after minor clarity feedback. Changes span +155/-159 lines.
74%
#496 refactor: Reduce cyclomatic complexity fetch-service merged Merged refactoring changes that reduced cyclomatic complexity by extracting logic into dedicated functions. Approved by two reviewers, passed CI checks, and modified four files (+248/-201 lines).
73%
#188 Small text cleanups for README and charmcraft help charmcraft merged Merged text cleanups for the README and charmcraft help documentation. Approved by two reviewers, the change updates 13 files to improve clarity while preserving test compatibility.
73%
#1622 fix: reorganise charmcraft.yaml preprocessing charmcraft merged Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines).
73%
#1556 refactor(tests/spread): test with explicit charmcraft.yaml files charmcraft merged Merged a refactor replacing dynamic charmcraft.yaml manipulation during the prepare step with explicit configuration files. Approved by three reviewers, the change simplifies testing for upcoming variants across nine modified files.
72%
#1520 refactor: remove old "init" command implementation charmcraft merged Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248.
72%
#289 fix: fix issues found in common.mk with charmcraft starbase merged Merged a fix for charmcraft issues in common.mk. Approved by two reviewers with zero unresolved comments. Changed two files, adding 11 and removing 7 lines.
72%
#1571 refactor: remove unused clean command implementation charmcraft merged Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files.
70%