← Back to issue list

style(types): update pyright

View original Github issue

Metadata

Project
craft-store
Number
#158
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.
qwen3.6-35b-a3b-mtp-q6 Merged updates to pyright configuration and type checking settings. Changes were integrated into the main branch without additional comments or revisions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#186 style(typing): update pyright craft-application merged Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions.
91%
#639 style: update pyright craft-parts merged Merged a style update to pyright via an automated codespell autofix. Approved by two reviewers, passed CI checks, and modified four files.
84%
#1574 style(type): enable stricter pyright rules charmcraft merged Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards.
83%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
81%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.
81%
#237 style: fix pyright config craft-cli merged Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
80%
#1525 build: enable pyright charmcraft merged Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff.
79%
#2052 style(type): make pyright stricter charmcraft merged Merged changes that enforce stricter pyright type checking by converting two warnings to errors and resolving the resulting type issues across 16 files.
78%
#1614 style(typing): enable most disabled pyright checks charmcraft merged Merged after approval by two reviewers, enabling most previously disabled pyright type checking rules. The update modifies 16 files (+94/-106 lines) to enforce stricter static type analysis across the codebase.
78%
#16 style: make pyright less concerned about grammar methods craft-grammar merged Merged a style update configuring pyright to reduce warnings for grammar methods. Approved by one reviewer, passed CI checks, and applied a minimal change of four additions and two deletions across one file.
77%