← Back to issue list

style(types): update pyright

View original Github issue

Metadata

Project
craft-store
Number
#158
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers.

Resolution: closed resolved

Reason: PR #158 was merged into main as commit 1b66727. Its two-file Pyright configuration update was approved by two reviewers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #158 (commit 1b66727), updating Pyright typing configuration in two files after approval by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#186 style(typing): update pyright craft-application merged Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20).
89%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.
79%
#639 style: update pyright craft-parts merged Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files.
78%
#1614 style(typing): enable most disabled pyright checks charmcraft merged Merged as commit 66952557, enabling most previously disabled Pyright checks and updating typing across 16 files.
78%
#1574 style(type): enable stricter pyright rules charmcraft merged Merged PR #1574 in commit 3445f5f4, enabling stricter Pyright type-checking rules across three files.
76%
#237 style: fix pyright config craft-cli merged Merged #237 (commit 675d42a), updating two Pyright ignore patterns so they apply recursively.
76%
#1294 style: enable strict type checking with pyright craft-parts merged Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files.
75%
#4233 type: workaround for pyright bug snapcraft merged Merged as f5b2f2e0f, adding a two-file typing workaround for microsoft/pyright#5394 after maintainer approval.
74%
#1528 Enable pyright and clear the typing issues charmcraft closed Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation.
73%
#65 Fixed new pyright issues. craft-cli merged Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479).
73%