← Back to issue list

style: silence ty warnings

View original Github issue

Metadata

Project
craft-cli
Number
#434
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #434 as commit ef91a65, adding targeted ty suppressions matching existing suppressions for other linters across two files.

Resolution: closed resolved

Reason: PR #434 was approved and merged into the project as commit ef91a65, resolving the reported ty warnings with five changed lines across two files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Silences some ty warnings that were already silenced for other linters.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #434 as commit ef91a65, adding targeted ty suppressions matching existing suppressions for other linters across two files.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-cli#434 to silence ty warnings already suppressed for other linters, with a five-line change across two files approved by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged to silence ty linter warnings, aligning with existing linter configurations. Approved by two reviewers and passed CI checks. The change modifies two files with five additions and five deletions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
86%
#335 fix(lint): suppress ty imagecraft merged Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed.
82%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
80%
#160 style: silence the ty job craft-platforms merged Merged PR #160 (commit 469db5d) by lengau silenced the experimental ty typecheck CI job and, as a drive-by, removed the leftover unused yamllint pre-commit hook; all CI checks passed.
76%
#2957 style: suppress ty diagnostics that block CI charmcraft closed Merged PR #2957 to fix CI `lint-ty` failures by suppressing 22 diagnostics and fixing a redundant cast.
74%
#2961 style: suppress ty diagnostics that block CI charmcraft merged Merged PR #2961 adds ty-specific lint ignores to match existing pyright/mypy configurations and removes a redundant cast in _expand_base, resolving CI blocks.
74%
#1361 style: suppress ty warning rockcraft merged One-line style PR adding a ty type-ignore to silence ty 0.0.79's false-positive warning that user_files["shadow"] is always "". Approved by one reviewer and merged (+1/-1, 1 file); source-spread-tests was the only red check.
73%
#5970 Fix `ty` warnings snapcraft closed Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
72%
#910 style: fix ty error craft-providers merged Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
71%
#27 ci: type check with ty craft-artifacts merged Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20.
70%