← Back to issue list

style: silence ty warnings

View original Github issue

Metadata

Project
craft-cli
Number
#434
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged to silence ty linter warnings, aligning with existing linter configurations. Approved by two reviewers and passed CI checks. The change modifies two files with five additions and five deletions.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Silences some ty warnings that were already silenced for other linters.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to silence ty linter warnings, aligning with existing linter configurations. Approved by two reviewers and passed CI checks. The change modifies two files with five additions and five deletions.
qwen3.6-35b-a3b-mtp-q6 Merged to silence ty linter warnings, aligning them with existing linter configurations. No review discussion was required.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#335 fix(lint): suppress ty imagecraft merged Merged after two approvals and passing CI checks. Fixes a lint failure by suppressing the ty rule across two files, modifying three lines of code.
75%
#6247 style: go all-in on ty snapcraft merged Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139.
75%
#1698 style: ty craft-parts merged Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review.
75%
#446 style(lint): fix typing for ty update craft-cli merged Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated.
75%
#242 style: fix ty linting error craft-platforms merged Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation.
75%
#6015 style: fix additional ty warnings snapcraft merged Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970.
74%
#6280 style: ty 0.0.44 snapcraft merged Merged update to ty version 0.0.44. Approved by two reviewers and passed core CI checks. Unrelated lint failures and integration timeouts did not block the merge.
73%
#429 feat(Makefile): add ty as an optional linter starbase merged Merged to add ty as an optional linter in the Makefile. Approved by two reviewers and passing all CI checks, the change adds 21 lines. The linter remains non-default due to pre-production status.
73%
#2726 style: switch type checking to ty charmcraft merged Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
72%
#1361 style: suppress ty warning rockcraft merged Merged a one-line change to suppress a ty 0.0.79 false positive on user_files["shadow"]. Approved by one reviewer and passed CI checks.
71%