setup: unpin linters and add additional linting tools
Metadata
Current evaluation
Merged changes unpinning legacy linters like mypy and flake8, adding pyright and isort for the updated codebase. Approved by reviewers, passed CI, and integrated without coverage changes.
Suggested action: —
No scores available.
Issue body
Legacy snapcraft code requires old versions of linting tools such as
mypy and flake8. Unpin the existing pinned linting tools and add
new linters such as pyright and isort, pointing them to the new
snapcraft code base.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes unpinning legacy linters like mypy and flake8, adding pyright and isort for the updated codebase. Approved by reviewers, passed CI, and integrated without coverage changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into snapcraft/7.0. Unpinned legacy linting tools like mypy and flake8, and added pyright and isort. Static and unit tests passed with zero coverage impact. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes unpinning legacy linters like mypy and flake8, and integrating pyright and isort for the snapcraft codebase. The update passed all checks and merged without affecting coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3852 lint: lint legacy code with isort | snapcraft | merged | Merged to re-enable isort linting for legacy code. Approved by a maintainer, passed all checks, and integrated into main without coverage changes. | |
| #4485 style(lint): fix pyright errors | snapcraft | merged | Merged after approval by three reviewers. Resolved pyright linting errors across nine files (+59/-38 lines). Codecov confirmed test coverage remained stable at 89.2%. | |
| #90 many: address new linter warnings (CRAFT-364) | craft-parts | merged | Merged after resolving new linter warnings from updated mypy and pylint versions, including silencing checks in tests. Approved by two reviewers, passed CI, and modified eight files (+32/-22 lines). | |
| #1207 style: replace mypy and pyright with ty | rockcraft | merged | Merged changes replacing mypy and pyright linting tools with ty. Approved by three reviewers and passed CI checks. Updates 43 files to streamline linting configuration and prepare for Starbase integration. | |
| #3672 linters: address issues and enable pylint in ci | snapcraft | merged | Merged after approval and CI pass. The PR addressed linter issues and enabled pylint in CI across 8 files. Changes increased test coverage by 0.02% with 100% diff coverage, successfully integrating static analysis into the pipeline. | |
| #3854 lint: lint legacy code with flake8 | snapcraft | merged | Merged into main following approval and passing CI. The change applies flake8 linting to legacy code across 17 files, modifying 31 additions and 36 deletions. Code coverage remains unchanged. | |
| #3813 lint: bump pylint | snapcraft | merged | Merged update bumping pylint to the latest version and removing the redundant disable: too-many-lines configuration. Approved, passed CI, and integrated into main as part of core22 architecture support. | |
| #66 lint: update pylint configuration | craft-store | merged | Merged an update to the pylint configuration, removing 627 lines of outdated settings and adding 16 lines with no functional changes. Approved by a reviewer and passed all CI checks. | |
| #36 Lint | imagecraft | merged | Merged a single-file linting adjustment with one addition and one deletion. The maintainer-submitted change required no reviews or CI checks before integration. | |
| #77 lint: fix linting issues with up-to-date linters | craft-store | merged | Merged a maintainer-submitted pull request resolving linting errors from updated linter versions. Approved by one reviewer, passed CI, and modified 11 files (+40/-24 lines). |