style(typing): enable most disabled pyright checks
Metadata
Current evaluation
Merged after approval by two reviewers, enabling most previously disabled pyright type checking rules. The update modifies 16 files (+94/-106 lines) to enforce stricter static type analysis across the codebase.
Suggested action: —
No scores available.
Issue body
It might be easier to review this commit by commit, which goes rule by rule
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval by two reviewers, enabling most previously disabled pyright type checking rules. The update modifies 16 files (+94/-106 lines) to enforce stricter static type analysis across the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer's pull request enabling most previously disabled pyright type checking rules. Changes were reviewed commit by commit to address each rule individually, successfully updating the project's static analysis configuration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer's pull request enabling most previously disabled pyright type checking rules. Changes were applied commit-by-commit to address individual rules, successfully improving static type analysis coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1574 style(type): enable stricter pyright rules | charmcraft | merged | Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards. | |
| #186 style(typing): update pyright | craft-application | merged | Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions. | |
| #2052 style(type): make pyright stricter | charmcraft | merged | Merged changes that enforce stricter pyright type checking by converting two warnings to errors and resolving the resulting type issues across 16 files. | |
| #158 style(types): update pyright | craft-store | merged | Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards. | |
| #1525 build: enable pyright | charmcraft | merged | Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff. | |
| #639 style: update pyright | craft-parts | merged | Merged a style update to pyright via an automated codespell autofix. Approved by two reviewers, passed CI checks, and modified four files. | |
| #1294 style: enable strict type checking with pyright | craft-parts | merged | Merged PR enabling strict type checking with pyright. All resulting type errors were resolved, improving the project's typing and linting status. The change passed CI checks and was approved, successfully integrating stricter type safety. | |
| #152 style: remove mypy and pyright to go all-in on ty | debcraft | merged | Merged changes removing mypy and pyright type checkers to exclusively use the ty tool. Approved by two reviewers, passed CI checks, and modified 12 files with a net reduction of 154 lines. | |
| #16 style: make pyright less concerned about grammar methods | craft-grammar | merged | Merged a style update configuring pyright to reduce warnings for grammar methods. Approved by one reviewer, passed CI checks, and applied a minimal change of four additions and two deletions across one file. | |
| #407 style(types): enable type checking with ty | craft-cli | merged | Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements. |