style(typing): enable most disabled pyright checks
Metadata
Current evaluation
Merged as commit 66952557, enabling most previously disabled Pyright checks and updating typing across 16 files.
Resolution: closed resolved
Reason: PR #1614 was approved by two reviewers and merged as commit 66952557, enabling the stricter Pyright rules and addressing the resulting typing issues.
Evaluated by: mr-cal-bot
No scores available.
Issue body
It might be easier to review this commit by commit, which goes rule by rule
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 66952557, enabling most previously disabled Pyright checks and updating typing across 16 files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1614 as commit 66952557, enabling most disabled Pyright checks and updating type-checking rules across 16 files after approval by two reviewers. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval by two reviewers, enabling most previously disabled pyright type checking rules. The update modifies 16 files (+94/-106 lines) to enforce stricter static type analysis across the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer's pull request enabling most previously disabled pyright type checking rules. Changes were reviewed commit by commit to address each rule individually, successfully updating the project's static analysis configuration. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#1574
(confidence 95%)
Earlier merged work introduced stricter Pyright rules that #1614 extended.
-
Related To:
charmcraft#1525
(confidence 90%)
This established Pyright with existing errors treated as warnings.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #186 style(typing): update pyright | craft-application | merged | Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20). | |
| #1574 style(type): enable stricter pyright rules | charmcraft | merged | Merged PR #1574 in commit 3445f5f4, enabling stricter Pyright type-checking rules across three files. | |
| #1294 style: enable strict type checking with pyright | craft-parts | merged | Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files. | |
| #158 style(types): update pyright | craft-store | merged | Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers. | |
| #639 style: update pyright | craft-parts | merged | Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files. | |
| #2052 style(type): make pyright stricter | charmcraft | merged | Merged PR canonical/charmcraft#2052, promoting two Pyright warnings to errors and fixing the resulting type errors across 16 files. | |
| #1528 Enable pyright and clear the typing issues | charmcraft | closed | Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated. | |
| #479 style: drop mypy, pyright | craft-cli | merged | Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed. | |
| #1525 build: enable pyright | charmcraft | merged | Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption. |