← Back to issue list

style: format pyproject.toml with tombi

View original Github issue

Metadata

Project
craft-grammar
Number
#218
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR formatting pyproject.toml with tombi to align with Starbase make format and make lint rules. Purely mechanical style changes.

Resolution: closed resolved

Reason: The PR was merged, applying tombi formatting to pyproject.toml to standardize key sorting and quoting across the project.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Summary Formats `pyproject.toml` with [tombi](https://github.com/tombi-toml/tombi), the TOML formatter that Starbase's `common.mk` now wires into `make format` (`format-tombi`) and `make lint` (`lint-tombi`). The diff is purely mechanical: key sorting and normalised quoting/indentation. No configuration value changes. ## Test plan - [x] `uv tool run tombi format --check --diff` clean - [x] `uv lock --check` passes (dependency set unchanged) - [x] `uv run pytest tests/unit` passes - [x] pre-commit hooks (including `check-toml`) pass

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Merged PR formatting pyproject.toml with tombi to align with Starbase make format and make lint rules. Purely mechanical style changes.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 7
Complexity: 20
Confidence: 85
Actionability: 55
keep open Mechanically formats pyproject.toml with tombi (key sorting, quoting, indentation); no config value changes. Approved by 2 reviewers; lint/files and OSV-scanner CI failing, expected until Starbase sync lands.
~deepseek/deepseek-pro-latest
Impact: 25
Quick Win: 12
Complexity: 25
Confidence: 75
Actionability: 65
needs review Mechanical tombi reformat of pyproject.toml (key sorting, quoting, indentation); no config changes. Approved but lint/files and OSV-scanner CI failing.
~deepseek/deepseek-pro-latest
Impact: 20
Quick Win: 4
Complexity: 25
Confidence: 70
Actionability: 30
keep open Formats pyproject.toml with tombi: key sorting and normalized quoting/indentation, no config value changes. CI failing lint/files and OSV-scanner; no reviews yet.
~deepseek/deepseek-pro-latest
Impact: 20
Quick Win: 4
Complexity: 30
Confidence: 70
Actionability: 30
keep open Formats pyproject.toml with tombi: key sorting, normalized quoting/indentation, no config value changes. CI failing lint/files and OSV-scanner; WIP pending; no reviewers.
~deepseek/deepseek-pro-latest
Impact: 15
Quick Win: 5
Complexity: 20
Confidence: 70
Actionability: 40
keep open Formats pyproject.toml with tombi; purely mechanical key sorting and quoting/indentation, no config changes. CI has failing lint/files and OSV-scanner checks, with WIP pending.

Update history

Date Change
merged
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#506 style: format pyproject.toml with tombi craft-cli merged Merged PR #506 mechanically reformats pyproject.toml with tombi to align with Starbase build tooling, containing no functional changes.
93%
#1213 style: format pyproject.toml with tombi craft-application merged Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync.
92%
#277 style: format pyproject.toml with tombi craft-platforms closed Merged as commit 14d9828, mechanically formatting pyproject.toml with tombi; the change was also folded into the Starbase update in #270.
92%
#200 style: format pyproject.toml with tombi debcraft merged Merged a mechanical reformat of pyproject.toml using tombi for indentation, quoting, and key ordering, preparing for the Starbase sync.
91%
#435 chore: format pyproject.toml with tombi craft-store merged Merged PR formatting pyproject.toml with tombi for consistent TOML formatting ahead of starbasification.
84%
#451 style: format TOML files with tombi imagecraft closed Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge.
84%
#2894 chore: format pyproject.toml with tombi ahead of Starbase merge charmcraft closed Superseded by #2898, which reapplied the tombi formatting and merged as f1af0486 ahead of the Starbase update in #2899.
78%
#436 chore: format pyproject.toml with tombi craft-store closed PR #436 was superseded by merged PR #435 (commit fe67242) which applied the same tombi formatting to pyproject.toml.
78%
#597 feat: format toml files with tombi starbase closed Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437.
77%
#437 Auto-format TOML files starbase closed TOML auto-formatting was implemented with tombi via PR #597, merged as commit 79fa93c, and added to formatting and lint targets.
73%