← Back to issue list

style: format pyproject.toml with tombi

View original Github issue

Metadata

Project
craft-cli
Number
#506
Type
pull request
State
merged
Author
dangertoaster
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #506 mechanically reformats pyproject.toml with tombi to align with Starbase build tooling, containing no functional changes.

Resolution: closed resolved

Reason: The pull request was merged, applying mechanical TOML formatting to pyproject.toml via tombi to prepare for the Starbase sync. All validation checks passed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

🤖 This message was generated by kimi-k3. ## Summary Purely mechanical reformatting of `pyproject.toml` with `tombi format` — no logic or configuration changes. The diff consists exclusively of: - Array indentation normalized (4-space → 2-space) - Key and table-section ordering normalized - Inline comment spacing normalized All values, comments, and semantics are unchanged; the full diff was inspected line-by-line to confirm. ## Motivation The shared Starcraft build tooling (canonical/starbase `common.mk`) adds `format-tombi`/`lint-tombi` targets that run `tombi format` over the repository's TOML files. Landing this mechanical reformat separately keeps the upcoming Starbase merge diff reviewable and lets this change be reverted independently if needed. ## Validation - `uv lock --check` — passed (no lockfile update needed) - `tombi format --check` — passes - `uv run pytest tests/unit -q` — 684 passed, 1 skipped ## Provenance Discovered while validating the Starbase sync merge for this repository: the updated `common.mk` from canonical/starbase adds the `format-tombi` and `lint-tombi` targets. This is a preparation PR for that starbase update.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #506 mechanically reformats pyproject.toml with tombi to align with Starbase build tooling, containing no functional changes.

Update history

Date Change
merged
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#277 style: format pyproject.toml with tombi craft-platforms closed Merged as commit 14d9828, mechanically formatting pyproject.toml with tombi; the change was also folded into the Starbase update in #270.
95%
#1213 style: format pyproject.toml with tombi craft-application merged Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync.
94%
#218 style: format pyproject.toml with tombi craft-grammar merged Merged PR formatting pyproject.toml with tombi to align with Starbase make format and make lint rules. Purely mechanical style changes.
93%
#200 style: format pyproject.toml with tombi debcraft merged Merged a mechanical reformat of pyproject.toml using tombi for indentation, quoting, and key ordering, preparing for the Starbase sync.
93%
#435 chore: format pyproject.toml with tombi craft-store merged Merged PR formatting pyproject.toml with tombi for consistent TOML formatting ahead of starbasification.
86%
#451 style: format TOML files with tombi imagecraft closed Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge.
86%
#597 feat: format toml files with tombi starbase closed Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437.
82%
#436 chore: format pyproject.toml with tombi craft-store closed PR #436 was superseded by merged PR #435 (commit fe67242) which applied the same tombi formatting to pyproject.toml.
81%
#2894 chore: format pyproject.toml with tombi ahead of Starbase merge charmcraft closed Superseded by #2898, which reapplied the tombi formatting and merged as f1af0486 ahead of the Starbase update in #2899.
80%
#2898 chore: format pyproject.toml with tombi ahead of Starbase merge charmcraft closed Closed unmerged after its prep branch was dropped during the Starbase update; replacement PR #2899 merged as commit 8da01822.
74%