Update qmake plugin to use get_build_properties
Metadata
Current evaluation
⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.
Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue.
Suggested action: —
No scores available.
Issue body
Updated the qmake.py plugin to use the get_build_properties() and get_pull_properties() method instead of modifying the schema.
Updated the test_plugin_qmake.py file to add test.
https://github.com/snapcore/snapcraft/pull/993
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged via pull request #993. The qmake plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with tests added to test_plugin_qmake.py. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | The cmake.py plugin was updated to use get_build_properties() instead of modifying the schema. The change was implemented and the issue closed as fixed. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged changes from pull request 999 update the autotools plugin to use get_build_properties() instead of modifying the schema. Tests were added to test_plugin_autotools.py, and the implementation was integrated into the codebase. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Resolved via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with updated tests. | |
| #1650626 Update python plugin to use get_pull_properties | snapcraft (launchpad) | closed | Updated the python plugin to use get_pull_properties() instead of modifying the schema, with tests added. The changes were merged via pull request #1002. | |
| #1650628 Update catkin plugin to use get_pull_properties | snapcraft (launchpad) | closed | Resolved by merging pull request #1001, which updated the catkin plugin to use get_pull_properties() instead of schema modification and added corresponding tests. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%. |