Update gulp plugin to use get_build_properties and get_pull_properties
Metadata
Current evaluation
⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.
Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests.
Suggested action: —
No scores available.
Issue body
Updated the gulp.py plugin to use the get_pull_properties() and get_build_properties() methods instead of modifying the schema.
Updated the gulp.py file to add test.
Updated schema test for gulp.
https://github.com/snapcore/snapcraft/pull/998
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Updated the gulp plugin to use get_build_properties() and get_pull_properties() instead of modifying the schema. Added and updated corresponding tests. The pull request was merged, implementing the requested changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to the gulp plugin, replacing schema modifications with get_build_properties() and get_pull_properties() methods. Includes corresponding test updates. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Resolved via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with updated tests. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Merged update to the Go plugin replacing schema modification with get_build_properties(), including corresponding test additions. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage. | |
| #996 Updated nodejs plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%. | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4. |