Update nodejs plugin to use get_build_properties and get_pull_properties
Metadata
Current evaluation
⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.
Resolved via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with updated tests.
Suggested action: —
No scores available.
Issue body
Updated the nodejs.py plugin to use the get_pull_properties() and get_build_properties() methods instead of modifying the schema.
Updated the test_plugin_nodejs.py file to add test.
Updated schema test for nodejs.
https://github.com/snapcore/snapcraft/pull/996
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Resolved via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with updated tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged via pull request #996, which updates the nodejs plugin to use get_build_properties() and get_pull_properties() instead of modifying the schema, with corresponding test updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of modifying the schema, with corresponding test updates. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #996 Updated nodejs plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks. | |
| #1650626 Update python plugin to use get_pull_properties | snapcraft (launchpad) | closed | Updated the python plugin to use get_pull_properties() instead of modifying the schema, with tests added. The changes were merged via pull request #1002. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Merged update to the Go plugin replacing schema modification with get_build_properties(), including corresponding test additions. | |
| #1650628 Update catkin plugin to use get_pull_properties | snapcraft (launchpad) | closed | Resolved by merging pull request #1001, which updated the catkin plugin to use get_pull_properties() instead of schema modification and added corresponding tests. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated. | |
| #1650597 Update kernel plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged via pull request #995. The kernel plugin was updated to use get_build_properties() instead of modifying the schema, with corresponding tests added to test_plugin_kernel.py. |