plugins: update go plugin to use get_build_properties()
Metadata
Current evaluation
Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests.
Resolution: closed resolved
Reason: PR #997 was approved and merged into master as commit 0b4239ce7. It completed the Go plugin migration and added tests for get_pull_properties() and get_build_properties().
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also updated schema test in unit tests.
Added tests for get_pull_properties() and get_build_properties() to test.
https://bugs.launchpad.net/snapcraft/+bug/1650606
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 0b4239ce7: Go plugin migrated to get_build_properties(), schema test updated, and unit tests added for get_pull_properties()/get_build_properties(). Part of a series addressing LP bug #1650606. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #997 merged as 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting the schema test, and adding unit tests for both property helpers. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the Go plugin to use get_build_properties(), revised schema tests, and added tests for get_pull_properties() and get_build_properties(). Maintained 96.34% coverage and resolves Launchpad bug #1650606. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603. | |
| #1000 Updated godeps plugin to use get_pull_properties() | snapcraft | merged | Merged PR #1000 in commit 9b8303005, updating the godeps plugin to use get_pull_properties() and adding schema and unit tests. | |
| #996 Updated nodejs plugin to use get_build_properties() | snapcraft | merged | Merged PR #996 updated Snapcraft's Node.js plugin to use get_build_properties()/get_pull_properties() and refreshed schema tests; landed as 2f0be3554. | |
| #1002 plugins: update python plugin to support get_pull_properties() | snapcraft | merged | Merged as commit dc26a14b2: python plugin gained get_pull_properties() support, with updated schema/unit tests, addressing Launchpad bug #1650626. | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #1022 plugins: update copy plugin to use get_build_properties(). | snapcraft | merged | Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series. |