Update catkin plugin to use get_pull_properties
Metadata
Current evaluation
⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.
Resolved by merging pull request #1001, which updated the catkin plugin to use get_pull_properties() instead of schema modification and added corresponding tests.
Suggested action: —
No scores available.
Issue body
Updated the catkin.py plugin to use the and get_pull_properties() methods instead of modifying the schema.
Updated the test_plugin_catkin.py file to add test.
https://github.com/snapcore/snapcraft/pull/1001
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Resolved by merging pull request #1001, which updated the catkin plugin to use get_pull_properties() instead of schema modification and added corresponding tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to the catkin plugin replacing schema modification with get_pull_properties(), including corresponding test additions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged pull request updating the catkin plugin to use get_pull_properties() instead of schema modification, with corresponding test additions. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines. | |
| #1650626 Update python plugin to use get_pull_properties | snapcraft (launchpad) | closed | Updated the python plugin to use get_pull_properties() instead of modifying the schema, with tests added. The changes were merged via pull request #1002. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Resolved via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with updated tests. | |
| #1002 plugins: update python plugin to support get_pull_properties() | snapcraft | merged | Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | The cmake.py plugin was updated to use get_build_properties() instead of modifying the schema. The change was implemented and the issue closed as fixed. | |
| #1650624 Update godeps plugin to use get_pull_properties | snapcraft (launchpad) | closed | Closed without implementation. The proposed refactoring to use get_pull_properties() instead of schema modification, along with new tests, was not merged or addressed. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged changes from pull request 999 update the autotools plugin to use get_build_properties() instead of modifying the schema. Tests were added to test_plugin_autotools.py, and the implementation was integrated into the codebase. |