Updated nodejs plugin to use get_build_properties()
Metadata
Current evaluation
Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%.
Suggested action: —
No scores available.
Issue body
Updated nodjs to use get_build_properties() and get_pull_properties()
Updated the schema testing in the unit tests.
Added get_build_properties() and get_pull_properties() to the test file.
https://bugs.launchpad.net/snapcraft/+bug/1650600
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the Node.js plugin to use get_build_properties() and get_pull_properties(), with corresponding unit test updates. Code coverage remained at 96.34%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the Node.js plugin to use get_build_properties() and get_pull_properties(), alongside corresponding unit and schema test updates. Code coverage remained stable at 96.34%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Resolved via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with updated tests. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests. | |
| #983 Updated scons plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and successful CI checks. The update refactored the scons plugin to use get_build_properties(), added demo and test files, and increased code coverage by 0.08%. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Merged update to the Go plugin replacing schema modification with get_build_properties(), including corresponding test additions. | |
| #1002 plugins: update python plugin to support get_pull_properties() | snapcraft | merged | Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge. |