Updated nodejs plugin to use get_build_properties()
Metadata
Current evaluation
Merged PR #996 updated Snapcraft's Node.js plugin to use get_build_properties()/get_pull_properties() and refreshed schema tests; landed as 2f0be3554.
Resolution: closed resolved
Reason: PR #996 was approved and merged into master in commit 2f0be3554, implementing the new plugin property hooks and corresponding unit tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated nodjs to use get_build_properties() and get_pull_properties()
Updated the schema testing in the unit tests.
Added get_build_properties() and get_pull_properties() to the test file.
https://bugs.launchpad.net/snapcraft/+bug/1650600
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #996 updated Snapcraft's Node.js plugin to use get_build_properties()/get_pull_properties() and refreshed schema tests; landed as 2f0be3554. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #996 (commit 2f0be3554): nodejs plugin migrated from deprecated build attributes to get_build_properties()/get_pull_properties(), with schema and unit test updates. Fixes Launchpad bug #1650600. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 2f0be3554: nodejs plugin now uses get_build_properties()/get_pull_properties() instead of mutating the part schema, with updated unit/schema tests for Launchpad bug #1650600. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#996 (2f0be3554), updating the nodejs plugin to use get_build_properties()/get_pull_properties() and revising schema and unit tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the Node.js plugin to use get_build_properties() and get_pull_properties(), with corresponding unit test updates. Code coverage remained at 96.34%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #1650597 Update kernel plugin to use get_build_properties | snapcraft (launchpad) | closed | Kernel plugin migration merged in commit fbd8887ac via snapcore/snapcraft#995, replacing schema mutation with get_build_properties() and adding tests. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests. | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. |