← Back to issue list

Update godeps plugin to use get_pull_properties

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1650624
Type
issue
State
closed
Author
~matt-aguirre
Labels
Created
Updated
Closed

Current evaluation

⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.

Closed without implementation. The proposed refactoring to use get_pull_properties() instead of schema modification, along with new tests, was not merged or addressed.

Suggested action:

No scores available.

Issue body

Updated the godeps.py plugin to use the and get_pull_properties() methods instead of modifying the schema. Updated the test_plugin_godeps.py file to add test.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without implementation. The proposed refactoring to use get_pull_properties() instead of schema modification, along with new tests, was not merged or addressed.
qwen/qwen3.6-35b-a3b Resolved by updating the godeps plugin to use get_pull_properties() instead of modifying the schema. Tests were added to verify the changes. The implementation was applied and the ticket closed.
qwen3.6-35b-a3b-mtp-q6 Proposed changes to replace schema modifications with get_pull_properties() in the godeps plugin were abandoned. The issue closed without merging the code or tests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1000 Updated godeps plugin to use get_pull_properties() snapcraft merged Merged changes updating the godeps plugin to use get_pull_properties() and adding corresponding unit tests. Approved by one reviewer with 96.33% code coverage across two files.
78%
#1650626 Update python plugin to use get_pull_properties snapcraft (launchpad) closed Updated the python plugin to use get_pull_properties() instead of modifying the schema, with tests added. The changes were merged via pull request #1002.
76%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation.
73%
#1650553 Update qmake plugin to use get_build_properties snapcraft (launchpad) closed Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue.
72%
#1650603 Update gulp plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests.
72%
#1002 plugins: update python plugin to support get_pull_properties() snapcraft merged Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge.
71%
#1650628 Update catkin plugin to use get_pull_properties snapcraft (launchpad) closed Resolved by merging pull request #1001, which updated the catkin plugin to use get_pull_properties() instead of schema modification and added corresponding tests.
71%
#1650600 Update nodejs plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Resolved via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with updated tests.
71%
#1649986 update maven plugin to use get_build_properties snapcraft (launchpad) closed The maven plugin was updated to use get_build_properties() instead of modifying the schema. The issue was closed after implementation.
70%