Updated godeps plugin to use get_pull_properties()
Metadata
Current evaluation
Merged changes updating the godeps plugin to use get_pull_properties() and adding corresponding unit tests. Approved by one reviewer with 96.33% code coverage across two files.
Suggested action: —
No scores available.
Issue body
Also updated schema test in unit tests.
Added tests for get_pull_properties() to test.
https://bugs.launchpad.net/snapcraft/+bug/1650624
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes updating the godeps plugin to use get_pull_properties() and adding corresponding unit tests. Approved by one reviewer with 96.33% code coverage across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after passing code coverage checks. Updated the godeps plugin to use get_pull_properties() and added corresponding unit tests and schema updates to resolve bug 1650624. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | The godeps plugin was updated to use get_pull_properties(), with corresponding unit and schema tests added. Changes passed 96.33% code coverage and were successfully merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650624 Update godeps plugin to use get_pull_properties | snapcraft (launchpad) | closed | Closed without implementation. The proposed refactoring to use get_pull_properties() instead of schema modification, along with new tests, was not merged or addressed. | |
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines. | |
| #1002 plugins: update python plugin to support get_pull_properties() | snapcraft | merged | Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge. | |
| #2200 tests: add spread suite for godeps plugin | snapcraft | merged | Merged changes move Godeps plugin integration tests to a Spread suite, resolving Launchpad bug #1783833. Approved by one reviewer, passed CI, and updated 12 files. Codecov noted a minor 0.08% coverage decrease. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated. | |
| #996 Updated nodejs plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%. | |
| #1650626 Update python plugin to use get_pull_properties | snapcraft (launchpad) | closed | Updated the python plugin to use get_pull_properties() instead of modifying the schema, with tests added. The changes were merged via pull request #1002. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks. | |
| #1179 godeps plugin: add git to build-packages | snapcraft | merged | Merged a patch adding git to the godeps plugin build-packages. The change resolves a missing dependency for go get commands. Approved by one reviewer and merged directly without CI checks. |