← Back to issue list

plugins: update python plugin to support get_pull_properties()

View original Github issue

Metadata

Project
snapcraft
Number
#1002
Type
pull request
State
merged
Author
ZenHarbinger
Labels
Created
Updated
Closed

Current evaluation

Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge.

Suggested action:

No scores available.

Issue body

Also updated schema test in unit tests. Added tests for get_pull_properties() to test. https://bugs.launchpad.net/snapcraft/+bug/1650626

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge.
qwen3.6-35b-a3b-mtp-q6 Merged update to the Python plugin enabling get_pull_properties() support. Added unit and schema tests. Code coverage held at 96.34% after the author corrected a test method rename.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Updated the Python plugin to support get_pull_properties() with corresponding unit and schema tests. Code coverage held at 96.34%. A test method rename was corrected before final integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1650626 Update python plugin to use get_pull_properties snapcraft (launchpad) closed Updated the python plugin to use get_pull_properties() instead of modifying the schema, with tests added. The changes were merged via pull request #1002.
87%
#1001 plugins: update catkin plugin to use get_pull_properties() snapcraft merged Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines.
82%
#997 plugins: update go plugin to use get_build_properties() snapcraft merged Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated.
80%
#998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() snapcraft merged Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks.
79%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%.
75%
#1000 Updated godeps plugin to use get_pull_properties() snapcraft merged Merged changes updating the godeps plugin to use get_pull_properties() and adding corresponding unit tests. Approved by one reviewer with 96.33% code coverage across two files.
75%
#996 Updated nodejs plugin to use get_build_properties() snapcraft merged Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%.
74%
#993 plugins: update qmake to use get_build_properties and get_pull_properties() snapcraft merged Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain.
74%
#1650628 Update catkin plugin to use get_pull_properties snapcraft (launchpad) closed Resolved by merging pull request #1001, which updated the catkin plugin to use get_pull_properties() instead of schema modification and added corresponding tests.
74%
#999 Updated autotools plugin to use get_build_properties() snapcraft merged Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage.
74%