plugins: update python plugin to support get_pull_properties()
Metadata
Current evaluation
Merged as commit dc26a14b2: python plugin gained get_pull_properties() support, with updated schema/unit tests, addressing Launchpad bug #1650626.
Resolution: closed resolved
Reason: The PR was approved and merged into master as commit dc26a14b2 ('plugins: update python plugin to support get_pull_properties() (#1002)'), converting the Python plugin's source-related properties to the new get_pull_properties() API and adding unit/schema test coverage for Launchpad bug 1650626.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also updated schema test in unit tests.
Added tests for get_pull_properties() to test.
https://bugs.launchpad.net/snapcraft/+bug/1650626
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit dc26a14b2: python plugin gained get_pull_properties() support, with updated schema/unit tests, addressing Launchpad bug #1650626. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit dc26a14b2, adding Python-plugin support for get_pull_properties() and unit/schema tests for Launchpad bug 1650626. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1002, updating the Python plugin to support get_pull_properties() and adding schema and unit tests. Merged as commit dc26a14b2. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged update to the Python plugin enabling get_pull_properties() support. Added unit and schema tests. Code coverage held at 96.34% after the author corrected a test method rename. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#998
(confidence 70%)
Sibling PR by the same effort updating the gulp plugin to get_build_properties()/get_pull_properties() (commit acf95e174)
-
Likely Fixed By:
canonical/snapcraft#1001
(confidence 70%)
Sibling PR updating the catkin plugin to use get_pull_properties() (commit 561a04341)
-
Likely Fixed By:
canonical/snapcraft#1000
(confidence 70%)
Sibling PR updating the godeps plugin to use get_pull_properties() (commit 9b8303005)
-
Likely Fixed By:
canonical/snapcraft#993
(confidence 65%)
Sibling PR updating the qmake plugin to the new pull-properties API (commit 2171f6367)
-
Related To:
snapcraft (launchpad)#1650626
(confidence 60%)
Launchpad bug 1650626 referenced in the PR body as the motivating defect
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged as commit 561a04341: updated the catkin plugin to use get_pull_properties(), refreshed schema tests, and added unit tests for Launchpad bug #1650628. | |
| #1650626 Update python plugin to use get_pull_properties | snapcraft (launchpad) | closed | Updated the Python plugin to use get_pull_properties() instead of modifying the schema, with tests, in snapcore/snapcraft PR #1002; merged as dc26a14b2. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608. | |
| #1000 Updated godeps plugin to use get_pull_properties() | snapcraft | merged | Merged PR #1000 in commit 9b8303005, updating the godeps plugin to use get_pull_properties() and adding schema and unit tests. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. | |
| #1650628 Update catkin plugin to use get_pull_properties | snapcraft (launchpad) | closed | Merged snapcraft#1001 in commit 561a04341, updating Catkin to use get_pull_properties() instead of modifying the schema and adding a unit test. | |
| #1647899 our plugins are using the deprecated pull properties | snapcraft (launchpad) | closed | Official plugins were migrated to get_pull_properties(); PR #1022 merged as e9e05f959, completing the final copy-plugin migration from deprecated schema pull properties. |