Update kernel plugin to use get_build_properties
Metadata
Current evaluation
Kernel plugin migration merged in commit fbd8887ac via snapcore/snapcraft#995, replacing schema mutation with get_build_properties() and adding tests.
Resolution: closed resolved
Reason: The referenced work landed as commit fbd8887ac, titled “plugins: update kernel plugin to use get_build_properties() (#995).” It updated the kernel plugin and its tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the kernel.py plugin to use the get_build_properties() method instead of modifying the schema.
Updated the test_plugin_kernel.py file to add test.
https://github.com/snapcore/snapcraft/pull/995
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Kernel plugin migration merged in commit fbd8887ac via snapcore/snapcraft#995, replacing schema mutation with get_build_properties() and adding tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Kernel plugin update merged in snapcore/snapcraft#995 (commit fbd8887ac), replacing direct schema changes with get_build_properties() and adding test coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the kernel plugin update to replace direct schema modification with the get_build_properties() method. Included updated tests in test_plugin_kernel.py. The change standardizes property retrieval and improves plugin maintainability. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged via pull request #995. The kernel plugin was updated to use get_build_properties() instead of modifying the schema, with corresponding tests added to test_plugin_kernel.py. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged via pull request #995. The kernel plugin was updated to use get_build_properties() instead of schema modification, and tests were added. The change is resolved. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Updated the kernel plugin to use get_build_properties() instead of schema modification, adding corresponding tests. The change was merged. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#995
(confidence 100%)
PR #995 was merged as commit fbd8887ac and directly implemented the requested plugin change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #995 plugins: update kernel plugin to use get_build_properties() | snapcraft | merged | Merged as commit fbd8887ac: kernel plugin migrated from directly setting source/target/arch properties to returning them via get_build_properties(), fixing Launchpad bug #1650597. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1794791 Update the kernel plugin to be base aware | snapcraft (launchpad) | closed | Kernel and KBuild plugins gained base support via merged PR snapcore/snapcraft#2368 (commit ddbda36b5). |