← Back to issue list

Update nodejs plugin to use get_build_properties and get_pull_properties

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1650600
Type
issue
State
closed
Author
~matt-aguirre
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests.

Resolution: closed resolved

Reason: Launchpad records the issue as merged in snapcore/snapcraft#996. Commit 2f0be3554 contains the Node.js plugin property-handling update and associated unit and schema tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Updated the nodejs.py plugin to use the get_pull_properties() and get_build_properties() methods instead of modifying the schema. Updated the test_plugin_nodejs.py file to add test. Updated schema test for nodejs. https://github.com/snapcore/snapcraft/pull/996

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#996 (2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of schema modification, with unit and schema tests.
qwen/qwen3.6-35b-a3b — — Merged changes updating the nodejs plugin to use get_build_properties() and get_pull_properties() instead of direct schema modification. Tests were updated accordingly.
qwen/qwen3.6-35b-a3b — — Resolved via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with updated tests.
qwen/qwen3.6-35b-a3b — — Merged via pull request #996, which updates the nodejs plugin to use get_build_properties() and get_pull_properties() instead of modifying the schema, with corresponding test updates.
qwen3.6-35b-a3b-mtp-q6 — — Merged via pull request #996. The nodejs plugin now uses get_build_properties() and get_pull_properties() instead of modifying the schema, with corresponding test updates.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#996 (confidence 100%)

    Merged PR implementing the requested plugin changes as commit 2f0be3554.

Related issues

Issue Project State Summary Similarity
#996 Updated nodejs plugin to use get_build_properties() snapcraft merged Merged PR #996 updated Snapcraft's Node.js plugin to use get_build_properties()/get_pull_properties() and refreshed schema tests; landed as 2f0be3554.
92%
#1650603 Update gulp plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests.
84%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests.
83%
#1650608 Update autotools plugin to use get_build_properties snapcraft (launchpad) closed Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6).
81%
#1650597 Update kernel plugin to use get_build_properties snapcraft (launchpad) closed Kernel plugin migration merged in commit fbd8887ac via snapcore/snapcraft#995, replacing schema mutation with get_build_properties() and adding tests.
81%
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3.
81%
#1650626 Update python plugin to use get_pull_properties snapcraft (launchpad) closed Updated the Python plugin to use get_pull_properties() instead of modifying the schema, with tests, in snapcore/snapcraft PR #1002; merged as dc26a14b2.
80%
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage.
80%
#1649986 update maven plugin to use get_build_properties snapcraft (launchpad) closed External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests.
79%
#1650553 Update qmake plugin to use get_build_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests.
79%