← Back to issue list

Update qmake plugin to use get_build_properties

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1650553
Type
issue
State
closed
Author
~matt-aguirre
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests.

Resolution: closed resolved

Reason: The linked PR #993 resolved the issue; its change is recorded in commit 2171f6367, which migrated the qmake plugin and updated test_plugin_qmake.py.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Updated the qmake.py plugin to use the get_build_properties() and get_pull_properties() method instead of modifying the schema. Updated the test_plugin_qmake.py file to add test. https://github.com/snapcore/snapcraft/pull/993

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests.
stealth/space-bunny-alpha — closed resolved Merged PR #993 (commit 2171f6367) updated qmake to use get_build_properties() and get_pull_properties() instead of schema changes, and added unit tests.
qwen/qwen3.6-35b-a3b — — Merged changes updating the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications. Added corresponding tests to test_plugin_qmake.py.
qwen/qwen3.6-35b-a3b — — Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue.
qwen3.6-35b-a3b-mtp-q6 — — Merged via pull request #993. The qmake plugin now uses get_build_properties() and get_pull_properties() instead of schema modification, with tests added to test_plugin_qmake.py.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#993 (confidence 100%)

    The issue body links this PR, and repository history identifies commit 2171f6367 as the corresponding qmake plugin change.

Related issues

Issue Project State Summary Similarity
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests.
85%
#993 plugins: update qmake to use get_build_properties and get_pull_properties() snapcraft merged Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553.
82%
#1650608 Update autotools plugin to use get_build_properties snapcraft (launchpad) closed Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6).
80%
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3.
80%
#1650600 Update nodejs plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests.
79%
#1649986 update maven plugin to use get_build_properties snapcraft (launchpad) closed External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests.
79%
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage.
78%
#1794799 Update the qmake plugin to be base aware snapcraft (launchpad) closed Updated the qmake plugin to support bases via snapcore/snapcraft PR #2366, merged as commit 3585eb13d.
77%
#1650547 Update ant plugin to use get_build_properties snapcraft (launchpad) closed Ant was updated to use get_build_properties() and register build properties for correct warnings; snapcore/snapcraft#991 merged as commit 65efd4678.
76%
#1650603 Update gulp plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests.
76%