Update autotools plugin to use get_build_properties
Metadata
Current evaluation
Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6).
Resolution: closed resolved
Reason: PR snapcore/snapcraft#999 was merged as commit 026fcfdf6, replacing schema modification with get_build_properties() and adding unit test coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the autotools.py plugin to use the and get_build_properties() methods instead of modifying the schema.
Updated the test_plugin_autotools.py file to add test.
https://github.com/snapcore/snapcraft/pull/999
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| stealth/space-bunny-alpha | — | closed resolved | Autotools migration to get_build_properties() was merged in snapcraft#999 via commit 026fcfdf6, with unit tests added. | |
| stealth/space-bunny-alpha | — | closed resolved | Autotools migration merged in PR #999 (commit 026fcfdf6), switching to get_build_properties() and updating unit tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes from pull request 999 update the autotools plugin to use get_build_properties() instead of modifying the schema. Tests were added to test_plugin_autotools.py, and the implementation was integrated into the codebase. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the autotools plugin to use get_build_properties() instead of schema modification, along with corresponding test additions. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request 999 updates the autotools plugin to use get_build_properties() instead of schema modification, including corresponding test updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged via pull request 999. The autotools plugin now uses get_build_properties() instead of modifying the schema, with corresponding test updates included in the main branch. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#999
(confidence 99%)
The referenced PR contains the autotools plugin change and resolves the issue as commit 026fcfdf6.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #1650079 Updated waf plugin to use get_build_properties() | snapcraft (launchpad) | closed | Waf plugin was updated to use get_build_properties() instead of modifying the schema in snapcore/snapcraft PR #979 (commit f8359e3cc). | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests. | |
| #1650597 Update kernel plugin to use get_build_properties | snapcraft (launchpad) | closed | Kernel plugin migration merged in commit fbd8887ac via snapcore/snapcraft#995, replacing schema mutation with get_build_properties() and adding tests. |