← Back to issue list

Update python plugin to use get_pull_properties

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1650626
Type
issue
State
closed
Author
~matt-aguirre
Labels
—
Created
Updated
Closed

Current evaluation

Updated the Python plugin to use get_pull_properties() instead of modifying the schema, with tests, in snapcore/snapcraft PR #1002; merged as dc26a14b2.

Resolution: closed resolved

Reason: The change was merged to the main codebase through snapcore/snapcraft PR #1002 in commit dc26a14b2 and added corresponding Python plugin test coverage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Updated the python.py plugin to use the and get_pull_properties() methods instead of modifying the schema. Updated the test_plugin_python.py file to add test. https://github.com/snapcore/snapcraft/pull/1002

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Updated the Python plugin to use get_pull_properties() instead of modifying the schema, with tests, in snapcore/snapcraft PR #1002; merged as dc26a14b2.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#1002 (dc26a14b2), replacing Python plugin schema mutation with get_pull_properties() and adding unit/schema tests.
qwen/qwen3.6-35b-a3b — — Updated the python plugin to use get_pull_properties() instead of modifying the schema. Changes were merged via pull request #1002, including corresponding test updates.
qwen/qwen3.6-35b-a3b — — Updated the python plugin to use get_pull_properties() instead of modifying the schema, with tests added. The changes were merged via pull request #1002.
qwen/qwen3.6-35b-a3b — — Merged as pull request #1002, updating the Python plugin to use get_pull_properties() instead of modifying the schema, with corresponding test additions.
qwen3.6-35b-a3b-mtp-q6 — — Updated the python plugin to use get_pull_properties() instead of modifying the schema, adding corresponding tests. The changes were merged via pull request #1002.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#1002 (confidence 100%)

    Merged commit dc26a14b2 implements get_pull_properties() support for the Python plugin.

Related issues

Issue Project State Summary Similarity
#1002 plugins: update python plugin to support get_pull_properties() snapcraft merged Merged as commit dc26a14b2: python plugin gained get_pull_properties() support, with updated schema/unit tests, addressing Launchpad bug #1650626.
85%
#1650600 Update nodejs plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests.
80%
#1650628 Update catkin plugin to use get_pull_properties snapcraft (launchpad) closed Merged snapcraft#1001 in commit 561a04341, updating Catkin to use get_pull_properties() instead of modifying the schema and adding a unit test.
78%
#1650624 Update godeps plugin to use get_pull_properties snapcraft (launchpad) closed Godeps was refactored to use get_pull_properties() with updated tests; merged via snapcore/snapcraft#1000 at commit 9b8303005.
77%
#1650608 Update autotools plugin to use get_build_properties snapcraft (launchpad) closed Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6).
76%
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3.
76%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests.
76%
#1000 Updated godeps plugin to use get_pull_properties() snapcraft merged Merged PR #1000 in commit 9b8303005, updating the godeps plugin to use get_pull_properties() and adding schema and unit tests.
74%
#1650603 Update gulp plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests.
74%
#1650553 Update qmake plugin to use get_build_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests.
73%