Update gulp plugin to use get_build_properties and get_pull_properties
Metadata
Current evaluation
Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests.
Resolution: closed resolved
Reason: The fix was merged in snapcore/snapcraft#998 at commit acf95e174. It replaced gulp schema modification with the property helpers and added corresponding tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the gulp.py plugin to use the get_pull_properties() and get_build_properties() methods instead of modifying the schema.
Updated the gulp.py file to add test.
Updated schema test for gulp.
https://github.com/snapcore/snapcraft/pull/998
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#998 as acf95e174, replacing gulp schema modifications with get_build_properties() and get_pull_properties() and adding unit and schema tests for Launchpad bug #1650603. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #998 in commit acf95e174, updating the Gulp plugin to use get_build_properties() and get_pull_properties() instead of modifying the schema, with unit and schema tests added. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request #998 to update the gulp plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, resolving the issue and adding corresponding tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Updated the gulp plugin to use get_build_properties() and get_pull_properties() instead of modifying the schema. Added and updated corresponding tests. The pull request was merged, implementing the requested changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to the gulp plugin, replacing schema modifications with get_build_properties() and get_pull_properties() methods. Includes corresponding test updates. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#998
(confidence 100%)
Merged commit acf95e174 implemented the requested gulp property-helper update and test coverage.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. | |
| #996 Updated nodejs plugin to use get_build_properties() | snapcraft | merged | Merged PR #996 updated Snapcraft's Node.js plugin to use get_build_properties()/get_pull_properties() and refreshed schema tests; landed as 2f0be3554. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #1650628 Update catkin plugin to use get_pull_properties | snapcraft (launchpad) | closed | Merged snapcraft#1001 in commit 561a04341, updating Catkin to use get_pull_properties() instead of modifying the schema and adding a unit test. |