← Back to issue list

refactor: move core22 commands for versioned implementation

View original Github issue

Metadata

Project
snapcraft
Number
#4586
Type
pull request
State
merged
Author
syu-w
Labels
Created
Updated
Closed

Current evaluation

Merged a pure rename refactor moving core22 commands for versioned implementation. Approved by four reviewers and passed CI. Full spread tests were enabled per request; failures attributed to external craft-application updates.

Suggested action:

No scores available.

Issue body

This is a pure rename with no code changes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a pure rename refactor moving core22 commands for versioned implementation. Approved by four reviewers and passed CI. Full spread tests were enabled per request; failures attributed to external craft-application updates.
qwen3.6-35b-a3b-mtp-q6 Merged a pure rename refactoring to relocate core22 commands for versioned implementation. Full spread tests were enabled per review. New failures stem from craft-application updates and will be addressed separately. Coverage remained stable.
qwen3.6-35b-a3b-mtp-q6 Merged a pure rename refactoring to move core22 commands for versioned implementation. Enabled full spread tests per review. New failures stem from craft-application dependency updates and will be handled separately.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5239 refactor: use craft-application's remote-build snapcraft merged Merged after three approvals. Author rebased to fix CLA. @mr-cal merged without waiting for core20 spread tests, as changes do not affect core20; related tests will run in PR #5259.
76%
#1520 refactor: remove old "init" command implementation charmcraft merged Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248.
75%
#4830 refactor: migrate commands to craft-application snapcraft merged Merged following three approvals and passing CI. Migrates remaining commands to core24/craft-application, updating snapcraft init to generate core24 files, correcting list-plugins output, and refreshing command docs. Resolves #4742.
73%
#1571 refactor: remove unused clean command implementation charmcraft merged Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files.
73%
#5007 refactor(application): commands, pre-run validation snapcraft merged Merged after approval and CI. Refactored command handling and pre-run validation using craft-cli groups. Improved error formatting, targeted SNAPCRAFT_REMOTE_BUILD_STRATEGY validation, and fixed core20/core24 compatibility. Resolves #4911 and #5008.
73%
#1572 refactor: remove unused extension command implementations charmcraft merged Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files.
72%
#4682 refactor(app): use more code from craft-app snapcraft merged Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines.
71%
#3870 plugins command: support for core22 snapcraft merged Merged changes adding core22 support to the plugins command and clarifying base selection messages. Approved by a reviewer, passed CI, and integrated into main despite a minor 0.04% coverage decrease.
71%
#3579 snap: move base to core20 (CRAFT-509) snapcraft merged Merged updates the snap base to core20. Approved by two reviewers with passing CI checks. Changes affect 13 files, increase coverage by 0.07%, and update initialization templates to core20.
71%
#521 refactor: port code to latest craft-app update rockcraft merged Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines).
71%