Updated autotools plugin to use get_build_properties()
Metadata
Current evaluation
Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608.
Resolution: closed resolved
Reason: PR #999 was approved and merged into master as commit 026fcfdf6, which replaced the autotools plugin's direct build/pull property access with get_build_properties() and updated the corresponding unit tests, fixing Launchpad bug #1650608.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also updated schema test in unit tests.
Added tests for get_pull_properties() to test.
https://bugs.launchpad.net/snapcraft/+bug/1650608
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #999 (commit 026fcfdf6), migrating the autotools plugin to get_build_properties() and updating its unit tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #999 updated autotools to use get_build_properties(), revised schema tests, and added get_pull_properties() tests (commit 026fcfdf6). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to master. Updated the autotools plugin to use get_build_properties(), refreshed schema unit tests, and added get_pull_properties() tests. Resolves Launchpad bug #1650608. Maintains 96.33% code coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#992
(confidence 70%)
Sibling merged PR updating the make plugin to get_build_properties() for a parallel Launchpad bug #1650548.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603. | |
| #1002 plugins: update python plugin to support get_pull_properties() | snapcraft | merged | Merged as commit dc26a14b2: python plugin gained get_pull_properties() support, with updated schema/unit tests, addressing Launchpad bug #1650626. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged as commit 561a04341: updated the catkin plugin to use get_pull_properties(), refreshed schema tests, and added unit tests for Launchpad bug #1650628. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. |