Updated kbuild plugin to use get_build_properties()
Metadata
Current evaluation
Superseded by #995, which merged the get_build_properties() update in commit fbd8887ac.
Resolution: closed superseded
Reason: The author closed #994 with the comment "Merged with #995." PR #995 was merged as commit fbd8887ac and delivered the corresponding plugin update.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated kbuild to use get_build_properties()
https://bugs.launchpad.net/snapcraft/+bug/1650595
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by #995, which merged the get_build_properties() update in commit fbd8887ac. | |
| stealth/space-bunny-alpha | — | closed resolved | Closed after the kbuild get_build_properties() update was merged with snapcraft#995 in commit fbd8887ac. | |
| stealth/space-bunny-alpha | — | closed superseded | kbuild work was consolidated into canonical/snapcraft#995, which merged the kernel-plugin get_build_properties() update in commit fbd8887ac. | |
| qwen/qwen3.6-35b-a3b | — | — | Updated the kbuild plugin to use get_build_properties(). The change was merged and consolidated with PR #995, closing the request without additional review. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | The kbuild plugin was updated to use get_build_properties(). The change was merged on December 16, 2016, and consolidated into PR #995. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#995
(confidence 99%)
The replacement PR was explicitly cited in #994's closing comment and merged in commit fbd8887ac.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. | |
| #991 Updated ant plugin to use get_build_properties() | snapcraft | merged | Merged PR #991 in commit 65efd4678, updating the Ant plugin to use get_build_properties() and register build-properties so warnings are emitted correctly. | |
| #979 Updated waf plugin to use get_build_properties() | snapcraft | merged | Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079). | |
| #995 plugins: update kernel plugin to use get_build_properties() | snapcraft | merged | Merged as commit fbd8887ac: kernel plugin migrated from directly setting source/target/arch properties to returning them via get_build_properties(), fixing Launchpad bug #1650597. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608. | |
| #1650597 Update kernel plugin to use get_build_properties | snapcraft (launchpad) | closed | Kernel plugin migration merged in commit fbd8887ac via snapcore/snapcraft#995, replacing schema mutation with get_build_properties() and adding tests. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. |