Updated cmake plugin to use get_build_properties()
Metadata
Current evaluation
Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage.
Suggested action: —
No scores available.
Issue body
https://bugs.launchpad.net/snapcraft/+bug/1650078
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, updating the cmake plugin to use get_build_properties(). The external contribution increased overall code coverage by 0.02% and was accepted without further changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, updating the cmake plugin to use get_build_properties() and resolving Launchpad bug #1650078. The change increased code coverage by 0.02%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #983 Updated scons plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and successful CI checks. The update refactored the scons plugin to use get_build_properties(), added demo and test files, and increased code coverage by 0.08%. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | The cmake.py plugin was updated to use get_build_properties() instead of modifying the schema. The change was implemented and the issue closed as fixed. | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%. | |
| #994 Updated kbuild plugin to use get_build_properties() | snapcraft | closed | Updated the kbuild plugin to use get_build_properties(). The change was merged and consolidated with PR #995, closing the request without additional review. | |
| #996 Updated nodejs plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain. | |
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines. |