Updated cmake plugin to use get_build_properties()
Metadata
Current evaluation
Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3.
Resolution: closed resolved
Reason: PR #978 was approved and merged. Commit 989177ee3 added get_build_properties() support to the CMake plugin.
Evaluated by: mr-cal-bot
No scores available.
Issue body
https://bugs.launchpad.net/snapcraft/+bug/1650078
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #978 updated the CMake plugin to implement get_build_properties(), resolving the build-properties API gap linked to Launchpad bug 1650078. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, updating the cmake plugin to use get_build_properties(). The external contribution increased overall code coverage by 0.02% and was accepted without further changes. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #994 Updated kbuild plugin to use get_build_properties() | snapcraft | closed | Superseded by #995, which merged the get_build_properties() update in commit fbd8887ac. | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. | |
| #1022 plugins: update copy plugin to use get_build_properties(). | snapcraft | merged | Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series. | |
| #991 Updated ant plugin to use get_build_properties() | snapcraft | merged | Merged PR #991 in commit 65efd4678, updating the Ant plugin to use get_build_properties() and register build-properties so warnings are emitted correctly. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553. | |
| #979 Updated waf plugin to use get_build_properties() | snapcraft | merged | Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079). |