plugins: update catkin plugin to use get_pull_properties()
Metadata
Current evaluation
Merged as commit 561a04341: updated the catkin plugin to use get_pull_properties(), refreshed schema tests, and added unit tests for Launchpad bug #1650628.
Resolution: closed resolved
Reason: PR #1001 was approved and merged into master as commit 561a04341, implementing the catkin plugin change with corresponding test coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also updated schema test in unit tests.
Added tests for get_pull_properties() to test.
https://bugs.launchpad.net/snapcraft/+bug/1650628
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 561a04341: updated the catkin plugin to use get_pull_properties(), refreshed schema tests, and added unit tests for Launchpad bug #1650628. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1001 updated the catkin plugin to use get_pull_properties() and added unit tests, addressing Launchpad bug #1650628. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the catkin plugin to use get_pull_properties() and added corresponding unit tests. Resolves Launchpad bug #1650628. Code coverage remains stable at 96.33%. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1650628
(confidence 99%)
The PR explicitly references this Launchpad bug, which requested the same catkin plugin migration.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650628 Update catkin plugin to use get_pull_properties | snapcraft (launchpad) | closed | Merged snapcraft#1001 in commit 561a04341, updating Catkin to use get_pull_properties() instead of modifying the schema and adding a unit test. | |
| #1002 plugins: update python plugin to support get_pull_properties() | snapcraft | merged | Merged as commit dc26a14b2: python plugin gained get_pull_properties() support, with updated schema/unit tests, addressing Launchpad bug #1650626. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553. | |
| #1650626 Update python plugin to use get_pull_properties | snapcraft (launchpad) | closed | Updated the Python plugin to use get_pull_properties() instead of modifying the schema, with tests, in snapcore/snapcraft PR #1002; merged as dc26a14b2. | |
| #1000 Updated godeps plugin to use get_pull_properties() | snapcraft | merged | Merged PR #1000 in commit 9b8303005, updating the godeps plugin to use get_pull_properties() and adding schema and unit tests. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. |