plugins: update catkin plugin to use get_pull_properties()
Metadata
Current evaluation
Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines.
Suggested action: —
No scores available.
Issue body
Also updated schema test in unit tests.
Added tests for get_pull_properties() to test.
https://bugs.launchpad.net/snapcraft/+bug/1650628
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the catkin plugin to use get_pull_properties() and added corresponding unit tests. Resolves Launchpad bug #1650628. Code coverage remains stable at 96.33%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, updating the catkin plugin to use get_pull_properties() and adding corresponding unit tests. The change resolves Launchpad bug 1650628 while maintaining 96.33% code coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650628 Update catkin plugin to use get_pull_properties | snapcraft (launchpad) | closed | Resolved by merging pull request #1001, which updated the catkin plugin to use get_pull_properties() instead of schema modification and added corresponding tests. | |
| #1002 plugins: update python plugin to support get_pull_properties() | snapcraft | merged | Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage. | |
| #1000 Updated godeps plugin to use get_pull_properties() | snapcraft | merged | Merged changes updating the godeps plugin to use get_pull_properties() and adding corresponding unit tests. Approved by one reviewer with 96.33% code coverage across two files. | |
| #993 plugins: update qmake to use get_build_properties and get_pull_properties() | snapcraft | merged | Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated. | |
| #995 plugins: update kernel plugin to use get_build_properties() | snapcraft | merged | Merged update to the kernel plugin switching it to get_build_properties(), resolving Launchpad bug #1650597. Approved by one reviewer, passed CI, and modified four files with a net coverage increase. | |
| #996 Updated nodejs plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%. | |
| #5729 docs: migrate 'the catkin-tools plugin' | snapcraft | merged | Merged documentation update migrating the catkin-tools plugin. Approved by two reviewers with all CI checks passing. Changes span three files, adding 87 lines and removing 5. |