Updated waf plugin to use get_build_properties()
Metadata
Current evaluation
Waf plugin was updated to use get_build_properties() instead of modifying the schema in snapcore/snapcraft PR #979 (commit f8359e3cc).
Resolution: closed resolved
Reason: The change was implemented and recorded by commit f8359e3cc, titled "waf plugin: implement get_build_properties() (#979)." The issue also links directly to that PR.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the waf.py plugin to use the get_build_properties() method instead of modifying the schema.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Waf plugin was updated to use get_build_properties() instead of modifying the schema in snapcore/snapcraft PR #979 (commit f8359e3cc). | |
| stealth/space-bunny-alpha | — | closed resolved | Waf plugin migrated to the get_build_properties() API instead of schema modification, delivered by snapcore/snapcraft PR #979 (commit f8359e3cc), which merged and closed this LP bug. | |
| stealth/space-bunny-alpha | — | closed resolved | Waf plugin update was merged in PR #979 (commit f8359e3cc), replacing schema modification with get_build_properties(). | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed by merged PR canonical/snapcraft#979 (commit f8359e3cc), updating waf.py to use get_build_properties() instead of modifying the schema. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved and closed after the waf.py plugin was updated to use get_build_properties() instead of modifying the schema. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed as fixed. The waf.py plugin was updated to use get_build_properties() instead of modifying the schema. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by updating the waf.py plugin to use get_build_properties() instead of modifying the schema, closing the issue. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Fixed by updating the waf plugin to use get_build_properties() instead of schema modification. Closed upon implementation. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#979
(confidence 100%)
PR #979 implemented the requested Waf plugin update and is referenced in the issue's closing discussion.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #979 Updated waf plugin to use get_build_properties() | snapcraft | merged | Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079). | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1650547 Update ant plugin to use get_build_properties | snapcraft (launchpad) | closed | Ant was updated to use get_build_properties() and register build properties for correct warnings; snapcore/snapcraft#991 merged as commit 65efd4678. | |
| #1794803 Update the waf plugin to be base aware | snapcraft (launchpad) | closed | Updated the Waf plugin to be base-aware by merging snapcore/snapcraft PR #2332 in commit bd896921b. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. |