← Back to issue list

Update ant plugin to use get_build_properties

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1650547
Type
issue
State
closed
Author
~matt-aguirre
Labels
—
Created
Updated
Closed

Current evaluation

Ant was updated to use get_build_properties() and register build properties for correct warnings; snapcore/snapcraft#991 merged as commit 65efd4678.

Resolution: closed resolved

Reason: The linked GitHub PR snapcore/snapcraft#991 was merged in commit 65efd4678, updating the Ant plugin and its unit tests to use get_build_properties().

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update ant plugin to use get_build_properties() Also updated unit test https://github.com/snapcore/snapcraft/pull/991

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Ant was updated to use get_build_properties() and register build properties for correct warnings; snapcore/snapcraft#991 merged as commit 65efd4678.
stealth/space-bunny-alpha — closed resolved Ant plugin updated to use get_build_properties() and register build attributes. Merged as PR snapcore/snapcraft#991, commit 65efd4678, with unit test updates.
stealth/space-bunny-alpha — closed resolved Ant plugin now uses get_build_properties() with updated unit tests, merged in PR #991 as commit 65efd4678.
stealth/space-bunny-alpha — closed resolved PR #991 was merged, updating the Ant plugin to use get_build_properties() and adding unit-test coverage in commit 65efd4678.
qwen/qwen3.6-35b-a3b — — Resolved by merging pull request #991, which updated the ant plugin to use get_build_properties() and added corresponding unit tests.
qwen/qwen3.6-35b-a3b — — Resolved via pull request #991. The ant plugin was updated to use get_build_properties(), with corresponding unit tests updated to match the implementation.
qwen/qwen3.6-35b-a3b — — Updated the ant plugin to use get_build_properties() and adjusted unit tests. The change was merged via pull request #991, closing the issue.
qwen3.6-35b-a3b-mtp-q6 — — Updated the ant plugin to use get_build_properties() and adjusted unit tests. The changes were merged via pull request #991, resolving the issue.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#991 (confidence 100%)

    Merged PR implementing the requested Ant plugin update and corresponding unit-test changes.

Related issues

Issue Project State Summary Similarity
#991 Updated ant plugin to use get_build_properties() snapcraft merged Merged PR #991 in commit 65efd4678, updating the Ant plugin to use get_build_properties() and register build-properties so warnings are emitted correctly.
85%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests.
79%
#1649986 update maven plugin to use get_build_properties snapcraft (launchpad) closed External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests.
78%
#1650608 Update autotools plugin to use get_build_properties snapcraft (launchpad) closed Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6).
78%
#1650079 Updated waf plugin to use get_build_properties() snapcraft (launchpad) closed Waf plugin was updated to use get_build_properties() instead of modifying the schema in snapcore/snapcraft PR #979 (commit f8359e3cc).
78%
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage.
77%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986.
77%
#1650600 Update nodejs plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests.
76%
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3.
76%
#1650553 Update qmake plugin to use get_build_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests.
76%