update scons plugin to use get_build_properties
Metadata
Current evaluation
SCons plugin migrated to get_build_properties(): upstream PR snapcore/snapcraft#983 merged as commit fe72cfd20, adding demos/scons/ and test_plugin_scons.py; issue closed once landed in master.
Resolution: closed resolved
Reason: The reporter linked snapcore/snapcraft#983, which was merged to master as commit fe72cfd20 ("scons plugin: implement get_build_properties() (#983)"), implementing the get_build_properties() method in snapcraft/plugins/scons.py instead of mutating the schema, and adding the demos/scons demo plus test_plugin_scons.py coverage. The Launchpad issue was then closed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the scons.py plugin to use the get_build_properties() method instead of modifying the schema.
Added demos/scons/
Added test_plugin_scons.py
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | SCons plugin migrated to get_build_properties(): upstream PR snapcore/snapcraft#983 merged as commit fe72cfd20, adding demos/scons/ and test_plugin_scons.py; issue closed once landed in master. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #983 (commit fe72cfd20) reworked the SCons plugin to implement get_build_properties() instead of altering the plugin schema, adding demos/scons and test_plugin_scons.py; landed in master and closed. | |
| stealth/space-bunny-alpha | — | closed resolved | SCons was updated to implement get_build_properties() in merged PR canonical/snapcraft#983 (commit fe72cfd20), with a demo and unit tests added. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged and closed. The scons plugin was updated to use get_build_properties() instead of schema modification, with new demo and test files added. | |
| qwen/qwen3.6-35b-a3b | — | — | Proposed changes to update the scons plugin to use get_build_properties() and add corresponding demo and test files were closed without implementation or merge. | |
| qwen/qwen3.6-35b-a3b | — | — | The scons plugin was updated to use get_build_properties() instead of schema modification. Demos and tests were added. The requested changes were implemented and the issue was closed as resolved. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed after merging updates to the scons plugin. The scons.py file now uses get_build_properties() instead of schema modification. Added demos/scons/ and test_plugin_scons.py. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#983
(confidence 96%)
PR cited by the reporter in the only comment; merged as commit fe72cfd20 with matching title.
-
Related To:
snapcore/snapcraft#1022
(confidence 72%)
Part of the same upstream series converting plugins (copy, kernel, gulp, qmake, go, nodejs, make, autotools) to get_build_properties().
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #983 Updated scons plugin to use get_build_properties() | snapcraft | merged | Merged into master via snapcraft#983 (commit fe72cfd20), updating SCons to use get_build_properties() and adding a demo and plugin tests. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1500758 scons plugin | snapcraft (launchpad) | closed | SCons plugin support was implemented in commit 25fb86397 after approval in 38a68cd78; later enhancements included options and build-properties support (#983). | |
| #1794801 Update the scons plugin to be base aware | snapcraft (launchpad) | closed | Updated the SCons plugin with base awareness in snapcore/snapcraft#2357, merged as commit 883c308c9. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. |