← Back to issue list

plugins: update copy plugin to use get_build_properties().

View original Github issue

Metadata

Project
snapcraft
Number
#1022
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series.

Resolution: closed resolved

Reason: PR #1022 was merged into master by maintainer kyrofa as commit e9e05f959 ("plugins: update copy plugin to use get_build_properties() (#1022)"), a +17/-4 change to snapcraft/plugins/copy.py. It completed the migration of all remaining plugins off deprecated properties, closing Launchpad bug #1647899.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR finishes LP: [#1647899](https://bugs.launchpad.net/snapcraft/+bug/1647899) as this is the last of the plugins using the deprecated properties.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series.
stealth/space-bunny-alpha — closed resolved Merged #1022 (commit e9e05f959), updating the copy plugin to use get_build_properties() and completing Launchpad #1647899.
qwen/qwen3.6-35b-a3b — — Merged into master. Updates the copy plugin to use get_build_properties(), replacing deprecated properties and completing Launchpad bug #1647899. The change spans two files with a +17/-4 line diff and achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Updates the copy plugin to use get_build_properties(), completing Launchpad bug #1647899 by removing deprecated property usage. Code coverage passed at 96.38%.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#995 (confidence 92%)

    Sibling PR converting the kernel plugin in the same get_build_properties() migration series (commit fbd8887ac).

  • Related To: canonical/snapcraft#998 (confidence 90%)

    Sibling PR converting gulp; part of the same deprecated-properties migration effort.

  • Related To: canonical/snapcraft#999 (confidence 88%)

    Sibling PR converting autotools, one of the last plugins updated before copy.

Related issues

Issue Project State Summary Similarity
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c.
81%
#979 Updated waf plugin to use get_build_properties() snapcraft merged Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079).
76%
#978 Updated cmake plugin to use get_build_properties() snapcraft merged Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3.
76%
#995 plugins: update kernel plugin to use get_build_properties() snapcraft merged Merged as commit fbd8887ac: kernel plugin migrated from directly setting source/target/arch properties to returning them via get_build_properties(), fixing Launchpad bug #1650597.
75%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series.
75%
#998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() snapcraft merged Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603.
74%
#994 Updated kbuild plugin to use get_build_properties() snapcraft closed Superseded by #995, which merged the get_build_properties() update in commit fbd8887ac.
73%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests.
73%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986.
73%
#997 plugins: update go plugin to use get_build_properties() snapcraft merged Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests.
72%