← Back to issue list

Updated scons plugin to use get_build_properties()

View original Github issue

Metadata

Project
snapcraft
Number
#983
Type
pull request
State
merged
Author
ZenHarbinger
Labels
Created
Updated
Closed

Current evaluation

Merged into master following reviewer approval and successful CI checks. The update refactored the scons plugin to use get_build_properties(), added demo and test files, and increased code coverage by 0.08%.

Suggested action:

No scores available.

Issue body

## Also added - demos/scons - test_plugin_scons.py https://bugs.launchpad.net/snapcraft/+bug/1650303

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master following reviewer approval and successful CI checks. The update refactored the scons plugin to use get_build_properties(), added demo and test files, and increased code coverage by 0.08%.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Updated the scons plugin to use get_build_properties(), added a demo and test file. The change improved overall code coverage by 0.08% and resolved the associated build configuration issue.
qwen3.6-35b-a3b-mtp-q6 Merged into master, updating the scons plugin to use get_build_properties() and adding demo and test files. Coverage increased by 0.08%, resolving Launchpad bug #1650303.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1650303 update scons plugin to use get_build_properties snapcraft (launchpad) closed Proposed changes to update the scons plugin to use get_build_properties() and add corresponding demo and test files were closed without implementation or merge.
85%
#978 Updated cmake plugin to use get_build_properties() snapcraft merged Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage.
85%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548.
76%
#996 Updated nodejs plugin to use get_build_properties() snapcraft merged Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%.
76%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4.
75%
#999 Updated autotools plugin to use get_build_properties() snapcraft merged Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage.
75%
#979 Updated waf plugin to use get_build_properties() snapcraft merged Merged an external contribution updating the waf plugin to use get_build_properties(). Approved by one reviewer with zero unresolved comments and passing CI checks. Code coverage increased by 0.01% upon merge.
74%
#994 Updated kbuild plugin to use get_build_properties() snapcraft closed Updated the kbuild plugin to use get_build_properties(). The change was merged and consolidated with PR #995, closing the request without additional review.
74%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%.
74%
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed The cmake.py plugin was updated to use get_build_properties() instead of modifying the schema. The change was implemented and the issue closed as fixed.
72%