Updated scons plugin to use get_build_properties()
Metadata
Current evaluation
Merged into master via snapcraft#983 (commit fe72cfd20), updating SCons to use get_build_properties() and adding a demo and plugin tests.
Resolution: closed resolved
Reason: PR #983 was approved and merged, resolving Launchpad bug #1650303. Commit fe72cfd20 implemented get_build_properties(), added demos/scons, and added test_plugin_scons.py.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Also added
- demos/scons
- test_plugin_scons.py
https://bugs.launchpad.net/snapcraft/+bug/1650303
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into master via snapcraft#983 (commit fe72cfd20), updating SCons to use get_build_properties() and adding a demo and plugin tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #983 updated the SCons plugin to use get_build_properties(), added a demo and tests, and landed in master. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit fe72cfd20: the SCons plugin now uses get_build_properties(), with added demo and unit-test coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master following reviewer approval and successful CI checks. The update refactored the scons plugin to use get_build_properties(), added demo and test files, and increased code coverage by 0.08%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the scons plugin to use get_build_properties(), added a demo and test file. The change improved overall code coverage by 0.08% and resolved the associated build configuration issue. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
snapcraft (launchpad)#1650303
(confidence 100%)
Linked Launchpad bug requesting the SCons get_build_properties() update; it was closed by the merged work.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650303 update scons plugin to use get_build_properties | snapcraft (launchpad) | closed | SCons plugin migrated to get_build_properties(): upstream PR snapcore/snapcraft#983 merged as commit fe72cfd20, adding demos/scons/ and test_plugin_scons.py; issue closed once landed in master. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #1500758 scons plugin | snapcraft (launchpad) | closed | SCons plugin support was implemented in commit 25fb86397 after approval in 38a68cd78; later enhancements included options and build-properties support (#983). | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. |