Update catkin plugin to use get_pull_properties
Metadata
Current evaluation
Merged snapcraft#1001 in commit 561a04341, updating Catkin to use get_pull_properties() instead of modifying the schema and adding a unit test.
Resolution: closed resolved
Reason: Commit 561a04341 implements the requested Catkin plugin change and adds test coverage; repository history identifies snapcraft#1001 as the resolving PR for Launchpad bug #1650628.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the catkin.py plugin to use the and get_pull_properties() methods instead of modifying the schema.
Updated the test_plugin_catkin.py file to add test.
https://github.com/snapcore/snapcraft/pull/1001
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged snapcraft#1001 in commit 561a04341, updating Catkin to use get_pull_properties() instead of modifying the schema and adding a unit test. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1001 updated catkin to use get_pull_properties() instead of modifying the schema and added unit tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the catkin plugin, replacing schema modification with get_pull_properties() and adding corresponding tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by merging pull request #1001, which updated the catkin plugin to use get_pull_properties() instead of schema modification and added corresponding tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to the catkin plugin replacing schema modification with get_pull_properties(), including corresponding test additions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged pull request updating the catkin plugin to use get_pull_properties() instead of schema modification, with corresponding test additions. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcraft#1001
(confidence 100%)
Merged resolving PR, committed as 561a04341.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged as commit 561a04341: updated the catkin plugin to use get_pull_properties(), refreshed schema tests, and added unit tests for Launchpad bug #1650628. | |
| #1650626 Update python plugin to use get_pull_properties | snapcraft (launchpad) | closed | Updated the Python plugin to use get_pull_properties() instead of modifying the schema, with tests, in snapcore/snapcraft PR #1002; merged as dc26a14b2. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #175 Catkin plugin: Refactor build. | snapcraft | merged | Merged in snapcraft#175 via commit 9045874fd, refactoring Catkin environment, dependency handling, build logic, source-space support, and tests. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1000 Updated godeps plugin to use get_pull_properties() | snapcraft | merged | Merged PR #1000 in commit 9b8303005, updating the godeps plugin to use get_pull_properties() and adding schema and unit tests. | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. |