Updated ant plugin to use get_build_properties()
Metadata
Current evaluation
Merged PR #991 in commit 65efd4678, updating the Ant plugin to use get_build_properties() and register build-properties so warnings are emitted correctly.
Resolution: closed resolved
Reason: PR canonical/snapcraft#991 was merged and committed as 65efd4678, resolving the Ant plugin's missing build-properties warning behavior.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Missed this plugin with my other batch because it never added to ['build-properties'] to throw the warning.
https://bugs.launchpad.net/snapcraft/+bug/1650547
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #991 in commit 65efd4678, updating the Ant plugin to use get_build_properties() and register build-properties so warnings are emitted correctly. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #991 updated the ant plugin to use get_build_properties() and register build properties, addressing the missing build-properties warning. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval, the ant plugin was updated to properly use get_build_properties() and register with the build-properties list, resolving a warning issue. The change added 18 lines across 3 files and passed all checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the ant plugin to use get_build_properties() and added it to the build-properties list to trigger warnings. Codecov verified 100% diff coverage. Resolved a missed plugin from a previous update. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#752
(confidence 90%)
Merged PR #752 introduced the Ant properties and build-target options later handled by the updated plugin.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650547 Update ant plugin to use get_build_properties | snapcraft (launchpad) | closed | Ant was updated to use get_build_properties() and register build properties for correct warnings; snapcore/snapcraft#991 merged as commit 65efd4678. | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series. | |
| #994 Updated kbuild plugin to use get_build_properties() | snapcraft | closed | Superseded by #995, which merged the get_build_properties() update in commit fbd8887ac. | |
| #979 Updated waf plugin to use get_build_properties() | snapcraft | merged | Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079). | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1022 plugins: update copy plugin to use get_build_properties(). | snapcraft | merged | Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests. |