Updated ant plugin to use get_build_properties()
Metadata
Current evaluation
Merged after approval, the ant plugin was updated to properly use get_build_properties() and register with the build-properties list, resolving a warning issue. The change added 18 lines across 3 files and passed all checks.
Suggested action: —
No scores available.
Issue body
Missed this plugin with my other batch because it never added to ['build-properties'] to throw the warning.
https://bugs.launchpad.net/snapcraft/+bug/1650547
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval, the ant plugin was updated to properly use get_build_properties() and register with the build-properties list, resolving a warning issue. The change added 18 lines across 3 files and passed all checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the ant plugin to use get_build_properties() and added it to the build-properties list to trigger warnings. Codecov verified 100% diff coverage. Resolved a missed plugin from a previous update. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the ant plugin to use get_build_properties(), fixing a missing warning for build properties referenced in Launchpad bug 1650547. Code coverage remains at 96.33%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650547 Update ant plugin to use get_build_properties | snapcraft (launchpad) | closed | Resolved by merging pull request #991, which updated the ant plugin to use get_build_properties() and added corresponding unit tests. | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage. | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | The maven plugin was updated to use get_build_properties() instead of modifying the schema. The issue was closed after implementation. | |
| #722 docs: document the Ant plugin | craft-parts | merged | Merged documentation update for the Ant plugin. Approved by two reviewers with minor feedback regarding the plugin build path. Changes span four files, adding 93 lines and removing 2. | |
| #979 Updated waf plugin to use get_build_properties() | snapcraft | merged | Merged an external contribution updating the waf plugin to use get_build_properties(). Approved by one reviewer with zero unresolved comments and passing CI checks. Code coverage increased by 0.01% upon merge. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548. | |
| #994 Updated kbuild plugin to use get_build_properties() | snapcraft | closed | Updated the kbuild plugin to use get_build_properties(). The change was merged and consolidated with PR #995, closing the request without additional review. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation. |